Migrate Document Outline to Fluent TreeView#82761
Draft
davkean wants to merge 1 commit intodotnet:mainfrom
Draft
Migrate Document Outline to Fluent TreeView#82761davkean wants to merge 1 commit intodotnet:mainfrom
davkean wants to merge 1 commit intodotnet:mainfrom
Conversation
dotnet-policy-service
bot
added
Community
- Replace VirtualizingTreeView with Fluent TreeView from Microsoft.VisualStudio.Shell.Controls - Remove WPF dotnet#122 workaround (VirtualizingTreeView.cs) - fix shipped in VS app-local WPF - Fluentize SearchControl with SearchControlToolBarStyleKey - Simplify XAML: remove manual selection indicator, SystemColors brush overrides, and old themed styles
davkean
force-pushed
the
dev/davkean/fluent-document-outline
branch
from
68b383f to
1f22a46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate Document Outline to Fluent TreeView
The Document Outline tool window used a custom
VirtualizingTreeViewsubclass of the standard WPF TreeView that worked around a WPF automation peer bug. That bug was fixed in 2022 (dotnet/wpf#7115) and the fix ships in VS's app-local WPF, making the workaround dead code.This PR:
VirtualizingTreeViewwith the FluentTreeViewfromMicrosoft.VisualStudio.Shell.ControlsVirtualizingTreeView.cs(the NRE in Automation Peers wpf#122 workaround is no longer needed)SearchControlToolBarStyleKeyCowritten with Copilot