Remove the CanonicalForked state from LanguageServerProjectLoader#82755
Draft
jasonmalinowski wants to merge 2 commits intodotnet:mainfrom
Draft
Remove the CanonicalForked state from LanguageServerProjectLoader#82755jasonmalinowski wants to merge 2 commits intodotnet:mainfrom
jasonmalinowski wants to merge 2 commits intodotnet:mainfrom
Conversation
This simplifies the approach being used for forked canonical projects and brings them back inline with how we do regular projects. A project where we want a forked canonical project for is initialized to being a primordial project like before, and then we update it to a real project via the usual mechanism. The trick is to treat the build host parameter to TryLoadProjectInMSBuildHostAsync as optional -- once we've built the canonical state we just don't need to use it again.
jasonmalinowski
force-pushed
the
get-rid-of-canonical-state
branch
from
fdf605d to
2eca09a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies the approach being used for forked canonical projects and brings them back inline with how we do regular projects. A project where we want a forked canonical project for is initialized to being a primordial project like before, and then we update it to a real project via the usual mechanism. The trick is to treat the build host parameter to TryLoadProjectInMSBuildHostAsync as optional -- once we've built the canonical state we just don't need to use it again.
Microsoft Reviewers: Open in CodeFlow