Skip to content

Allow for better parallelization with brokered services #82733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jasonmalinowski wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

Allow for better parallelization with brokered services #82733

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Workspaces/Remote/Core/ServiceDescriptor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,10 @@ protected override IJsonRpcMessageFormatter CreateFormatter()

protected override JsonRpcConnection CreateConnection(JsonRpc jsonRpc)
{
// The default synchronization context set by the base type is NonConcurrentSynchronizationContext, which means that all incoming calls
// would be processed sequentially, at least up until their first await. We generally don't have services that expect ordering in that specific way, so
// disable that, especially since we want CPU-bound operations to happen in parallel.
jsonRpc.SynchronizationContext = null;
Copy link
Member

@dibarbet dibarbet Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this apply to all brokered service usages - or just devenv -> oop? (e.g. does this apply to vscode brokered services)

Copy link
Member Author

@jasonmalinowski jasonmalinowski Mar 12, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dibarbet As best I know, everything, VS Code included.

jsonRpc.CancelLocallyInvokedMethodsWhenConnectionIsClosed = true;
var connection = base.CreateConnection(jsonRpc);
connection.LocalRpcTargetOptions = s_jsonRpcTargetOptions;
Expand Down
Loading