Unsafe evolution: add warning for unsafe delegates#82730
Open
jjonescz wants to merge 2 commits intodotnet:mainfrom
Open
Unsafe evolution: add warning for unsafe delegates#82730jjonescz wants to merge 2 commits intodotnet:mainfrom
unsafe delegates#82730jjonescz wants to merge 2 commits intodotnet:mainfrom
Conversation
jcouv
reviewed
Mar 12, 2026
| using System.Threading; | ||
| using Microsoft.CodeAnalysis; | ||
| using Microsoft.CodeAnalysis.CSharp.Emit; | ||
| using Microsoft.CodeAnalysis.CSharp.Symbols.PublicModel; |
jcouv
approved these changes
Mar 12, 2026
Member
jcouv
left a comment
jcouv
left a comment
There was a problem hiding this comment.
LGTM Thanks (commit 1) modulo unnecessary using
Member
Author
|
@333fred for another review, thanks |
333fred
approved these changes
Mar 16, 2026
Member
333fred
left a comment
333fred
left a comment
There was a problem hiding this comment.
LGTM other than a suggestion on wording.
| <comment>'RequiresUnsafe', 'extern', and 'new()' should not be localized. {2} is the generic method or type.</comment> | ||
| </data> | ||
| <data name="WRN_UnsafeMeaningless" xml:space="preserve"> | ||
| <value>The 'unsafe' modifier does not have any effect here under the current rules.</value> |
Member
There was a problem hiding this comment.
Suggested change
| <value>The 'unsafe' modifier does not have any effect here under the current rules.</value> | |
| <value>The 'unsafe' modifier does not have any effect here under the memory safety current rules.</value> |
| <comment>'unsafe' is a keyword, should not be localized.</comment> | ||
| </data> | ||
| <data name="WRN_UnsafeMeaningless_Title" xml:space="preserve"> | ||
| <value>The 'unsafe' modifier does not have any effect here under the current rules.</value> |
Member
There was a problem hiding this comment.
Suggested change
| <value>The 'unsafe' modifier does not have any effect here under the current rules.</value> | |
| <value>The 'unsafe' modifier does not have any effect here under the memory safety current rules.</value> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test plan: #81207
Microsoft Reviewers: Open in CodeFlow