Add UpscaleFilter to SVE microbenchmark#5038
Open
ylpoonlg wants to merge 6 commits intodotnet:mainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Arm64 SVE microbenchmark that measures an upscale filter implementation across scalar, AdvSimd (Vector128), and SVE2 code paths, and updates the microbenchmark project file to only compile this new SVE2 benchmark on TFMs that support the required intrinsics APIs.
Changes:
- Added
UpscaleFilterSVE benchmark with Scalar, Vector128, and SVE2 implementations plus result verification. - Updated
MicroBenchmarks.csprojto excludeUpscaleFilter.csfor target frameworks older thannet10.0.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/benchmarks/micro/sve/UpscaleFilter.cs | New SVE benchmark implementing and validating an upscale filter with multiple SIMD paths. |
| src/benchmarks/micro/MicroBenchmarks.csproj | Adds TFM-conditional compilation to exclude the new SVE2 benchmark on TFMs < net10.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the upscale filter function to SVE benchmark.
Performance Results
Run on Neoverse-V2
cc @dotnet/arm64-contrib @SwapnilGaikwad @LoopedBard3