Skip to content

Refactor projection binding to avoid redundant Convert nodes and impr… #37625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Abde1rahman1 wants to merge 16 commits into
base: main
Choose a base branch
from

attempt 5

a724d05
Select commit
Loading
Failed to load commit list.
Draft

Refactor projection binding to avoid redundant Convert nodes and impr… #37625

attempt 5
a724d05
Select commit
Loading
Failed to load commit list.
Azure Pipelines / efcore-ci failed Feb 18, 2026 in 57m 15s

Build #20260218.21 had test failures

5 errors / 4 warnings

Details

Tests

  • Failed: 718 (0.28%)
  • Passed: 224,522 (87.11%)
  • Other: 32,493 (12.61%)
  • Total: 257,733

Annotations

Check failure on line 0 in XUnit

See this annotation in the file changed.

@azure-pipelines azure-pipelines / efcore-ci

XUnit#L0 

XUnit(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Tests failed: /home/vsts/work/1/s/artifacts/TestResults/Release/EFCore.Sqlite.FunctionalTests_net11.0_x64.html [net11.0|x64]

Check failure on line 0 in XUnit

See this annotation in the file changed.

@azure-pipelines azure-pipelines / efcore-ci

XUnit#L0 

XUnit(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Tests failed: D:\a\_work\1\s\artifacts\TestResults\Release\EFCore.Sqlite.FunctionalTests_net11.0_x64.html [net11.0|x64]

Check failure on line 0 in XUnit

See this annotation in the file changed.

@azure-pipelines azure-pipelines / efcore-ci

XUnit#L0 

XUnit(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Tests failed: D:\a\_work\1\s\artifacts\TestResults\Release\EFCore.SqlServer.FunctionalTests_net11.0_x64.html [net11.0|x64]

Check failure on line 0 in XUnit

See this annotation in the file changed.

@azure-pipelines azure-pipelines / efcore-ci

XUnit#L0 

XUnit(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Tests failed: /Users/runner/work/1/s/artifacts/TestResults/Release/EFCore.Sqlite.FunctionalTests_net11.0_x64.html [net11.0|x64]

Check failure on line 1 in Microsoft.EntityFrameworkCore.Query.Associations.ComplexJson.ComplexJsonCollectionSqliteTest.GroupBy

See this annotation in the file changed.

@azure-pipelines azure-pipelines / efcore-ci

Microsoft.EntityFrameworkCore.Query.Associations.ComplexJson.ComplexJsonCollectionSqliteTest.GroupBy 

System.InvalidOperationException : The LINQ expression 'StructuralTypeShaperExpression(
    StructuralType: Associations.RootEntity
    ValueBufferExpression: ProjectionBindingExpression: EmptyProjectionMember
    IsNullable: False).AssociateCollection
    .AsQueryable()
    .GroupBy(c => c.String)
    .Select(g => g
        .AsQueryable()
        .Sum(e => e.Int))
    .Contains(16)' could not be translated. Either rewrite the query in a form that can be translated, or switch to client evaluation explicitly by inserting a call to 'AsEnumerable', 'AsAsyncEnumerable', 'ToList', or 'ToListAsync'. See https://go.microsoft.com/fwlink/?linkid=2101038 for more information.
Raw output 
   at Microsoft.EntityFrameworkCore.Query.QueryableMethodTranslatingExpressionVisitor.Translate(Expression expression) in D:\a\_work\1\s\src\EFCore\Query\QueryableMethodTranslatingExpressionVisitor.cs:line 66
   at Microsoft.EntityFrameworkCore.Query.QueryableMethodTranslatingExpressionVisitor.TranslateSubquery(Expression expression) in D:\a\_work\1\s\src\EFCore\Query\QueryableMethodTranslatingExpressionVisitor.cs:line 670
   at Microsoft.EntityFrameworkCore.Query.RelationalSqlTranslatingExpressionVisitor.<VisitMethodCall>g__TranslateAsSubquery|31_0(Expression expression, <>c__DisplayClass31_0&) in D:\a\_work\1\s\src\EFCore.Relational\Query\RelationalSqlTranslatingExpressionVisitor.cs:line 1016
   at Microsoft.EntityFrameworkCore.Query.RelationalSqlTranslatingExpressionVisitor.VisitMethodCall(MethodCallExpression methodCallExpression) in D:\a\_work\1\s\src\EFCore.Relational\Query\RelationalSqlTranslatingExpressionVisitor.cs:line 943
   at Microsoft.EntityFrameworkCore.Sqlite.Query.Internal.SqliteSqlTranslatingExpressionVisitor.VisitMethodCall(MethodCallExpression methodCallExpression) in D:\a\_work\1\s\src\EFCore.Sqlite.Core\Query\Internal\SqliteSqlTranslatingExpressionVisitor.cs:line 210
   at Microsoft.EntityFrameworkCore.Query.RelationalSqlTranslatingExpressionVisitor.TranslateInternal(Expression expression, Boolean applyDefaultTypeMapping) in D:\a\_work\1\s\src\EFCore.Relational\Query\RelationalSqlTranslatingExpressionVisitor.cs:line 149
   at Microsoft.EntityFrameworkCore.Query.RelationalSqlTranslatingExpressionVisitor.Translate(Expression expression, Boolean applyDefaultTypeMapping) in D:\a\_work\1\s\src\EFCore.Relational\Query\RelationalSqlTranslatingExpressionVisitor.cs:line 113
   at Microsoft.EntityFrameworkCore.Query.RelationalQueryableMethodTranslatingExpressionVisitor.TranslateExpression(Expression expression, Boolean applyDefaultTypeMapping) in D:\a\_work\1\s\src\EFCore.Relational\Query\RelationalQueryableMethodTranslatingExpressionVisitor.cs:line 1496
   at Microsoft.EntityFrameworkCore.Query.RelationalQueryableMethodTranslatingExpressionVisitor.TranslateLambdaExpression(ShapedQueryExpression shapedQueryExpression, LambdaExpression lambdaExpression) in D:\a\_work\1\s\src\EFCore.Relational\Query\RelationalQueryableMethodTranslatingExpressionVisitor.cs:line 1533
   at Microsoft.EntityFrameworkCore.Query.RelationalQueryableMethodTranslatingExpressionVisitor.TranslateWhere(ShapedQueryExpression source, LambdaExpression predicate) in D:\a\_work\1\s\src\EFCore.Relational\Query\RelationalQueryableMethodTranslatingExpressionVisitor.cs:line 1475
   at Microsoft.EntityFrameworkCore.Query.QueryableMethodTranslatingExpressionVisitor.VisitMethodCall(MethodCallExpression methodCallExpression) in D:\a\_work\1\s\src\EFCore\Query\QueryableMethodTranslatingExpressionVisitor.cs:line 583
   at Microsoft.EntityFrameworkCore.Query.RelationalQueryableMethodTranslatingExpressionVisitor.VisitMethodCall(MethodCallExpression methodCallExpression) in D:\a\_work\1\s\src\EFCore.Relational\Query\RelationalQueryableMethodTranslatingExpressionVisitor.cs:line 249
   at Microsoft.EntityFrameworkCore.Query.QueryableMethodTranslatingExpressionVisitor.Translate(Expression expression) in D:\a\_work\1\s\src\EFCore\Query\QueryableMethodTranslatingExpressionVisitor.cs:line 52
   at Microsoft.EntityFrameworkCore.Query.QueryCompilationContext.CreateQueryExecutorExpression[TResult](Expression query) in D:\a\_work\1\s\src\EFCore\Query\QueryCompilationContext.cs:line 210
   at Microsoft.EntityFrameworkCore.Query.QueryCompilationContext.CreateQueryExecutor[TResult](Expression query) in D:\a\_work\1\s\src\EFCore\Query\QueryCompilationContext.cs:line 177
   at Microsoft.EntityFrameworkCore.Storage.Database.CompileQuery[TResult](Expression query, Boolean async) in D:\a\_work\1\s\src\EFCore\Storage\Database.cs:line 64
   at Microsoft.EntityFrameworkCore.Query.Internal.QueryCompiler.CompileQueryCore[TResult](IDatabase database, Expression query, IModel model, Bool

Check failure on line 1 in Microsoft.EntityFrameworkCore.Query.Associations.ComplexJson.ComplexJsonCollectionSqliteTest.Select_within_Select_within_Select_with_aggregates

See this annotation in the file changed.

@azure-pipelines azure-pipelines / efcore-ci

Microsoft.EntityFrameworkCore.Query.Associations.ComplexJson.ComplexJsonCollectionSqliteTest.Select_within_Select_within_Select_with_aggregates 

System.InvalidOperationException : The LINQ expression 'StructuralTypeShaperExpression(
    StructuralType: Associations.RootEntity
    ValueBufferExpression: ProjectionBindingExpression: EmptyProjectionMember
    IsNullable: False).AssociateCollection
    .AsQueryable()
    .Select(c => c.NestedCollection
        .AsQueryable()
        .Select(c0 => c0.Int)
        .Max())
    .Sum()' could not be translated. Either rewrite the query in a form that can be translated, or switch to client evaluation explicitly by inserting a call to 'AsEnumerable', 'AsAsyncEnumerable', 'ToList', or 'ToListAsync'. See https://go.microsoft.com/fwlink/?linkid=2101038 for more information.
Raw output 
   at Microsoft.EntityFrameworkCore.Query.QueryableMethodTranslatingExpressionVisitor.Translate(Expression expression) in D:\a\_work\1\s\src\EFCore\Query\QueryableMethodTranslatingExpressionVisitor.cs:line 66
   at Microsoft.EntityFrameworkCore.Query.QueryableMethodTranslatingExpressionVisitor.TranslateSubquery(Expression expression) in D:\a\_work\1\s\src\EFCore\Query\QueryableMethodTranslatingExpressionVisitor.cs:line 670
   at Microsoft.EntityFrameworkCore.Query.RelationalSqlTranslatingExpressionVisitor.<VisitMethodCall>g__TranslateAsSubquery|31_0(Expression expression, <>c__DisplayClass31_0&) in D:\a\_work\1\s\src\EFCore.Relational\Query\RelationalSqlTranslatingExpressionVisitor.cs:line 1016
   at Microsoft.EntityFrameworkCore.Query.RelationalSqlTranslatingExpressionVisitor.VisitMethodCall(MethodCallExpression methodCallExpression) in D:\a\_work\1\s\src\EFCore.Relational\Query\RelationalSqlTranslatingExpressionVisitor.cs:line 943
   at Microsoft.EntityFrameworkCore.Sqlite.Query.Internal.SqliteSqlTranslatingExpressionVisitor.VisitMethodCall(MethodCallExpression methodCallExpression) in D:\a\_work\1\s\src\EFCore.Sqlite.Core\Query\Internal\SqliteSqlTranslatingExpressionVisitor.cs:line 210
   at Microsoft.EntityFrameworkCore.Query.RelationalSqlTranslatingExpressionVisitor.TranslateInternal(Expression expression, Boolean applyDefaultTypeMapping) in D:\a\_work\1\s\src\EFCore.Relational\Query\RelationalSqlTranslatingExpressionVisitor.cs:line 149
   at Microsoft.EntityFrameworkCore.Query.RelationalSqlTranslatingExpressionVisitor.TranslateProjection(Expression expression, Boolean applyDefaultTypeMapping) in D:\a\_work\1\s\src\EFCore.Relational\Query\RelationalSqlTranslatingExpressionVisitor.cs:line 127
   at Microsoft.EntityFrameworkCore.Query.Internal.RelationalProjectionBindingExpressionVisitor.Visit(Expression expression) in D:\a\_work\1\s\src\EFCore.Relational\Query\Internal\RelationalProjectionBindingExpressionVisitor.cs:line 250
   at Microsoft.EntityFrameworkCore.Query.Internal.RelationalProjectionBindingExpressionVisitor.Translate(SelectExpression selectExpression, Expression expression) in D:\a\_work\1\s\src\EFCore.Relational\Query\Internal\RelationalProjectionBindingExpressionVisitor.cs:line 62
   at Microsoft.EntityFrameworkCore.Query.RelationalQueryableMethodTranslatingExpressionVisitor.TranslateSelect(ShapedQueryExpression source, LambdaExpression selector) in D:\a\_work\1\s\src\EFCore.Relational\Query\RelationalQueryableMethodTranslatingExpressionVisitor.cs:line 1155
   at Microsoft.EntityFrameworkCore.Query.QueryableMethodTranslatingExpressionVisitor.VisitMethodCall(MethodCallExpression methodCallExpression) in D:\a\_work\1\s\src\EFCore\Query\QueryableMethodTranslatingExpressionVisitor.cs:line 499
   at Microsoft.EntityFrameworkCore.Query.RelationalQueryableMethodTranslatingExpressionVisitor.VisitMethodCall(MethodCallExpression methodCallExpression) in D:\a\_work\1\s\src\EFCore.Relational\Query\RelationalQueryableMethodTranslatingExpressionVisitor.cs:line 249
   at Microsoft.EntityFrameworkCore.Query.QueryableMethodTranslatingExpressionVisitor.Translate(Expression expression) in D:\a\_work\1\s\src\EFCore\Query\QueryableMethodTranslatingExpressionVisitor.cs:line 52
   at Microsoft.EntityFrameworkCore.Query.QueryCompilationContext.CreateQueryExecutorExpression[TResult](Expression query) in D:\a\_work\1\s\src\EFCore\Query\QueryCompilationContext.cs:line 210
   at Microsoft.EntityFrameworkCore.Query.QueryCompilationContext.CreateQueryExecutor[TResult](Expression query) in D:\a\_work\1\s\src\EFCore\Query\QueryCompilationContext.cs:line 177
   at Microsoft.EntityFrameworkCore.Storage.Database.CompileQuery[TResult](Expression query, Boolean async) in D:\a\_work\1\s\src\EFCore\Storage\Database.cs:line 64
   at Microsoft.EntityFrameworkCore.Query.Internal.QueryCompiler.CompileQueryCore[TResult](IDatabase database, Expression query, IModel model, Boolean async) in D:\a\_work\1\s\src\EFCore\Query\Internal\QueryCompiler.cs:line 1

Check failure on line 1 in Microsoft.EntityFrameworkCore.CustomConvertersSqliteTest.Optional_owned_with_converter_reading_non_nullable_column

See this annotation in the file changed.

@azure-pipelines azure-pipelines / efcore-ci

Microsoft.EntityFrameworkCore.CustomConvertersSqliteTest.Optional_owned_with_converter_reading_non_nullable_column 

Assert.Throws() Failure: No exception was thrown
Expected: typeof(System.InvalidOperationException)
Raw output 
   at Microsoft.EntityFrameworkCore.CustomConvertersTestBase`1.Optional_owned_with_converter_reading_non_nullable_column() in D:\a\_work\1\s\test\EFCore.Specification.Tests\CustomConvertersTestBase.cs:line 690
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Check failure on line 1 in Microsoft.EntityFrameworkCore.Query.ComplexTypeQuerySqliteTest.Subquery_over_struct_complex_type

See this annotation in the file changed.

@azure-pipelines azure-pipelines / efcore-ci

Microsoft.EntityFrameworkCore.Query.ComplexTypeQuerySqliteTest.Subquery_over_struct_complex_type 

Test failed
View more details on Azure Pipelines