Skip to content

Fix VS NuGet restore loop caused by VSSDK property name conflict #16594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −3
Open

Fix VS NuGet restore loop caused by VSSDK property name conflict #16594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12a57fd
Initial plan
Copilot Mar 17, 2026
7b65aaf
Fix VS NuGet restore loop by renaming VSSDK property, adding opt-out,…
Copilot Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Documentation/ArcadeSdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,6 +596,7 @@ Set `VSSDKTargetPlatformRegRootSuffix` property to specify the root suffix of th

If `source.extension.vsixmanifest` is present next to a project file the project is by default considered to be a VSIX producing project (`IsVsixProject` property is set to true).
A package reference to `Microsoft.VSSDK.BuildTools` is automatically added to such project.
Set `IncludeMicrosoftVSSDKBuildToolsPackageReference` to `false` to opt out of the automatic package reference (e.g. if you need to manage the version yourself).

Arcade SDK include build target for generating VS Template VSIXes. Adding `VSTemplate` items to project will trigger the target.

Expand Down
7 changes: 6 additions & 1 deletion src/Microsoft.DotNet.Arcade.Sdk/tools/DefaultVersions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,12 @@
<MicroBuildPluginsSwixBuildVersion Condition="'$(MicroBuildPluginsSwixBuildVersion)' == ''">1.0.422</MicroBuildPluginsSwixBuildVersion>
<MicrosoftDotNetIBCMergeVersion Condition="'$(MicrosoftDotNetIBCMergeVersion)' == ''">5.1.0-beta.21356.1</MicrosoftDotNetIBCMergeVersion>
<MicrosoftNETTestSdkVersion Condition="'$(MicrosoftNETTestSdkVersion)' == ''">18.0.1</MicrosoftNETTestSdkVersion>
<MicrosoftVSSDKBuildToolsVersion Condition="'$(MicrosoftVSSDKBuildToolsVersion)' == ''">16.9.1050</MicrosoftVSSDKBuildToolsVersion>
<!--
Note: The property name intentionally does NOT follow the convention of 'MicrosoftVSSDKBuildToolsVersion'
because the Microsoft.VSSDK.BuildTools package itself redefines that property to a different value,
which causes NuGet restores to go in a loop. See https://github.com/dotnet/arcade/issues/15594.
-->
<MicrosoftVSSDKBuildToolsDefaultVersion Condition="'$(MicrosoftVSSDKBuildToolsDefaultVersion)' == ''">17.14.2120</MicrosoftVSSDKBuildToolsDefaultVersion>
<MicrosoftDotnetNuGetRepackTasksVersion Condition="'$(MicrosoftDotnetNuGetRepackTasksVersion)' == ''">$(ArcadeSdkVersion)</MicrosoftDotnetNuGetRepackTasksVersion>
<MicrosoftDotNetSignToolVersion Condition="'$(MicrosoftDotNetSignToolVersion)' == ''">$(ArcadeSdkVersion)</MicrosoftDotNetSignToolVersion>
<MicrosoftDotNetTarVersion Condition="'$(MicrosoftDotNetTarVersion)' == ''">$(ArcadeSdkVersion)</MicrosoftDotNetTarVersion>
Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.DotNet.Arcade.Sdk/tools/VisualStudio.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
<PackageReference Include="Microsoft.VisualStudioEng.MicroBuild.Plugins.SwixBuild" Version="$(MicrosoftVisualStudioEngMicroBuildPluginsSwixBuildVersion)" PrivateAssets="all" IsImplicitlyDefined="true" />
</ItemGroup>

<ItemGroup Condition="'$(IsVsixProject)' == 'true' or '$(GeneratePkgDefFile)' == 'true'">
<PackageReference Include="Microsoft.VSSDK.BuildTools" Version="$(MicrosoftVSSDKBuildToolsVersion)" PrivateAssets="all" IsImplicitlyDefined="true" />
<ItemGroup Condition="('$(IsVsixProject)' == 'true' or '$(GeneratePkgDefFile)' == 'true') and '$(IncludeMicrosoftVSSDKBuildToolsPackageReference)' != 'false'">
<PackageReference Include="Microsoft.VSSDK.BuildTools" Version="$(MicrosoftVSSDKBuildToolsDefaultVersion)" PrivateAssets="all" IsImplicitlyDefined="true" />
</ItemGroup>

<!-- Returns the current build version. Used in .vsixmanifests to substitute our build version into them -->
Expand Down
Loading