ci(release): skip docs PR when CLI reference is unchanged#786
Merged
doringeman merged 2 commits intomainfrom Mar 25, 2026
Merged
ci(release): skip docs PR when CLI reference is unchanged#786doringeman merged 2 commits intomainfrom
doringeman merged 2 commits intomainfrom
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The AWK one-liner that strips the second
requireblock ingo.modis fairly brittle (e.g., relies on exactrequire (...)formatting and ordering); consider usinggo mod editor a small Go/scripted helper that programmatically removes the unwanted requirements so it’s more robust to future formatting changes. - The
gh api ... compare/${PREVIOUS_TAG}...${RELEASE_TAG}call will fail if either tag is missing or misaligned with thedocker/model-runnerrepo; you may want a guard (or a try/catch-style fallback) so that a transient tag/compare issue doesn’t cause the whole release workflow to fail.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The AWK one-liner that strips the second `require` block in `go.mod` is fairly brittle (e.g., relies on exact `require (...)` formatting and ordering); consider using `go mod edit` or a small Go/scripted helper that programmatically removes the unwanted requirements so it’s more robust to future formatting changes.
- The `gh api ... compare/${PREVIOUS_TAG}...${RELEASE_TAG}` call will fail if either tag is missing or misaligned with the `docker/model-runner` repo; you may want a guard (or a try/catch-style fallback) so that a transient tag/compare issue doesn’t cause the whole release workflow to fail.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Dorin Geman <dorin.geman@docker.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Dorin Geman <dorin.geman@docker.com>
ilopezluna
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The update-docs job now checks whether any files under cmd/cli/docs/reference/ changed between the previous and current release tags before opening a PR in docker/docs. If no CLI reference docs changed, all subsequent steps are skipped.
When the PR is created, the second require block that go get adds to go.mod (containing all transitive dependencies of model-runner) is stripped after vendoring, so the PR only contains the model-runner version bump in the existing require block.
Test run for unchanged files: https://github.com/docker/model-runner/actions/runs/23498364715/job/68385961940.