Skip to content

fix(e2e): send SIGINT on teardown to prevent orphan processes #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
doringeman wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Open

fix(e2e): send SIGINT on teardown to prevent orphan processes #785

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions e2e/e2e_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,11 @@ func run(m *testing.M) int {
defer cancel()

server := exec.CommandContext(ctx, serverBin)
// TODO: os.Interrupt is not supported on Windows. When Windows e2e
// tests are added, use a platform-specific shutdown mechanism.
server.Cancel = func() error {
return server.Process.Signal(os.Interrupt)
}
server.Dir = root
server.Env = append(os.Environ(),
"MODEL_RUNNER_PORT="+strconv.Itoa(port),
Expand Down
Loading