docs: clarify Bake environment variable override behavior#3728
docs: clarify Bake environment variable override behavior#3728crazy-max merged 1 commit intodocker:masterfrom
Conversation
| default = "$HOME" | ||
| default = "/root" | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Seems it got removed by mistake
There was a problem hiding this comment.
Addressed feedback . PTAL 🙏
dvdksn
left a comment
dvdksn
left a comment
There was a problem hiding this comment.
Looks good, just needs the closing ``` added back!
tonistiigi
left a comment
tonistiigi
left a comment
There was a problem hiding this comment.
Is this a place where it's worth to mention BUILDX_BAKE_DISABLE_VARS_ENV_LOOKUP as well.
allexistence
force-pushed
the
docs-clarify-bake-env-override
branch
2 times, most recently
from
386af6b to
f63107e
Compare
|
Addressed feedback:
PTAL 🙏 |
crazy-max
left a comment
crazy-max
left a comment
There was a problem hiding this comment.
Can you squash your commits please? Thx
allexistence
force-pushed
the
docs-clarify-bake-env-override
branch
from
f63107e to
997ed69
Compare
Signed-off-by: rishabh <rishank69@gmail.com> docs: address review feedback on bake env lookup Signed-off-by: rishabh <rishank69@gmail.com>
allexistence
force-pushed
the
docs-clarify-bake-env-override
branch
from
997ed69 to
8bcf041
Compare
PTAL |
Yes this is marked as docs follow-up to document this new var: #3595 @dvdksn Seems we have other things left to cover for docs: https://github.com/docker/buildx/pulls?q=is%3Apr+label%3Astatus%2Fneeds-docs-follow-up+is%3Aclosed |
4 participants
Summary
Clarifies the Bake reference docs for environment variable behavior.
The previous wording and example suggested that values like
$HOMEareinterpolated in the
defaultfield. In practice, Bake overrides a declaredvariable when an environment variable with the same name is set.
Changes
default = "$HOME"exampleRelated: