dap: defer inputs for a step to prevent overeager evaluation#3687
Open
jsternberg wants to merge 1 commit intodocker:masterfrom
Open
dap: defer inputs for a step to prevent overeager evaluation#3687jsternberg wants to merge 1 commit intodocker:masterfrom
jsternberg wants to merge 1 commit intodocker:masterfrom
Conversation
jsternberg
force-pushed
the
dap-filter-inputs
branch
from
c8ca678 to
bc1992b
Compare
jsternberg
force-pushed
the
dap-filter-inputs
branch
from
bc1992b to
067eaf4
Compare
jsternberg
force-pushed
the
dap-filter-inputs
branch
from
067eaf4 to
63a8fc3
Compare
jsternberg
changed the title
jsternberg
force-pushed
the
dap-filter-inputs
branch
3 times, most recently
from
627e79c to
ca1832a
Compare
When the debug thread was updated to always solve inputs from the operation that it was tied to it became a bit overeager to evaluate them. The intention of the steps is to have a single direct parent and then potentially multiple "function calls" that can be evaluated with step into and step out to leave. With the change, that logic stayed in, but the inputs were always being evaluated before they were stepped into or over. Now, when we construct the steps, we also attach a list of inputs that we should defer evaluation on to ensure we don't execute inputs that haven't been executed yet. It will then wrap the reference with a version that causes `Evaluate` to do nothing. This prevents the overeager evaluation but allows the reference to be evaluated if we need to read the filesystem. Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
jsternberg
force-pushed
the
dap-filter-inputs
branch
from
ca1832a to
0e46e23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the debug thread was updated to always solve inputs from the
operation that it was tied to it became a bit overeager to evaluate
them. The intention of the steps is to have a single direct parent and
then potentially multiple "function calls" that can be evaluated with
step into and step out to leave.
With the change, that logic stayed in, but the inputs were always being
evaluated before they were stepped into or over. Now, when we construct
the steps, we also attach a list of inputs that we should defer
evaluation on to ensure we don't execute inputs that haven't been
executed yet.
It will then wrap the reference with a version that causes
Evaluatetodo nothing. This prevents the overeager evaluation but allows the
reference to be evaluated if we need to read the filesystem.