Fix browser back trough latest version#932
Open
tbuerli-komax wants to merge 2 commits intodocat-org:mainfrom
Open
Fix browser back trough latest version#932tbuerli-komax wants to merge 2 commits intodocat-org:mainfrom
tbuerli-komax wants to merge 2 commits intodocat-org:mainfrom
Conversation
…st" version, when the version is for example called v1.0.1, by splitting version and displayVersion in the code
…Context Providers to keep their state, to prevent them from showing outdated information a reloadIntervalSeconds with a default of 30s was introduced, to prevent flickering on project updates a diff logic was introduced before the state update and the iframe was adapted to only refresh if the current version changes. For example, adding versions to other Projects should not refresh the iframe nor should the iframe update when older versions get added to a Project.
Member
|
Hoi 👋 thanks for your contribution can you please break this down into smaller merge requests? In the current state this is very hard to review.
I don't think this is a feature we want to support so you can drop it completely, which should resolve the need to document it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: Browser back navigation doesn't work when navigating back through the "latest" version.
How to reproduce:
Changes done:
I hope this matches the coding style of the repository. It was a bit unclear to me where the documentation for the
reloadIntervalSecondsshould go. Is this better in the main README.md as an example parameter or in the web/README.md as an additional section?