[PEP389] introduce argparse deprecate optparse#5425
Open
nausikt wants to merge 5 commits intodmwm:masterfrom
Open
[PEP389] introduce argparse deprecate optparse#5425nausikt wants to merge 5 commits intodmwm:masterfrom
nausikt wants to merge 5 commits intodmwm:masterfrom
Conversation
…createmyproxy. replace with add_argument.
|
Jenkins results:
|
Member
|
Hi @nausikt I tried to understand this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #5424
The hardest part is preserving the strict
disable_interspersed_argsbehaviour and adding back the validating of unknown flags in CRABOptParser.py.Thanks to LLM, helping me polish this part meanwhile we both looking at original optparse.py
So, CRABOptParser in general + submit, createmyproxy subcommands will behave exactly the same.
See also the important bit disable_interspersed_args
P.S. Let me exhaustively test first (may write some unit-tests), do we already have test cases covered these behaviors?
P.S. Besides that, I think my proposed abstraction/structure is fairly minimal and clean. what do you think?