Skip to content

Fix duplicate unique constraint for device_code (#1656)#1659

Open
febin-micheal wants to merge 2 commits intodjango-oauth:masterfrom
febin-micheal:fix-oracle-device-grant-issue
Open

Fix duplicate unique constraint for device_code (#1656)#1659
febin-micheal wants to merge 2 commits intodjango-oauth:masterfrom
febin-micheal:fix-oracle-device-grant-issue

Conversation

@febin-micheal
Copy link
Copy Markdown

@febin-micheal febin-micheal commented Feb 27, 2026

Fixes #1656

Description of the Change

This PR fixes issue #1656 by removing the second UniqueConstraint definition from DeviceGrant that causes ORA-02261 on Oracle 19c deployments. Verified locally that this doesn't break PostgreSQL logic and added tests passing.
Also added febin-micheal to authors and #1656 to changelog.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS
  • tests/app/idp updated to demonstrate new features
  • tests/app/rp updated to demonstrate new features

@dopry dopry force-pushed the fix-oracle-device-grant-issue branch from fca45b2 to 982d25d Compare March 12, 2026 19:48
@dopry dopry requested a review from Copilot March 12, 2026 19:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DeviceGrant table definition breaks in Oracle 19c env

2 participants