Fix: safe access to applyNumberFormat attribute#312
Open
junstudys wants to merge 1 commit intodilshod:masterfrom
Open
Fix: safe access to applyNumberFormat attribute#312junstudys wants to merge 1 commit intodilshod:masterfrom
junstudys wants to merge 1 commit intodilshod:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix KeyError exception when directly accessing applyNumberFormat attribute at line 613 of xlsx2csv.py.
Problem: When applyNumberFormat attribute does not exist in cellXfs._attrs, using cellXfs._attrs['applyNumberFormat'] directly raises a KeyError.
Solution: Use cellXfs._attrs.get('applyNumberFormat', 0) for safe access, returning default value 0 when the attribute is missing.
Changes: xlsx2csv.py:613 — changed direct access to .get() safe access