feat: Project Invite Flow (Screens Only) and Practice Mode#695
Open
feat: Project Invite Flow (Screens Only) and Practice Mode#695
Conversation
ErikSin
changed the title
achou11
reviewed
Aug 2, 2022
Member
achou11
left a comment
achou11
left a comment
There was a problem hiding this comment.
Overall looks solid so far! left some relatively minor comments but can re-review when remaining items are addressed
| }, | ||
| "renderer.components.Settings.ProjectConfig.joinProject": { | ||
| "description": "Button to join a new project", | ||
| "message": "Join A Project" |
Member
There was a problem hiding this comment.
confirm that A is capitalized in the copy deck?
| font-size: 0.8rem; | ||
| color: ${buildConfig.variant === 'icca' ? '#eeeeee' : '#aaaaaa'}; | ||
| ` | ||
| // {buildConfig.variant === 'icca' ? '#eeeeee' : '#aaaaaa'}; |
Comment on lines
+241
to
+243
| const resetInvite = useCallback(() => { | ||
| setInvite(null) | ||
| }, [setInvite]) |
Member
There was a problem hiding this comment.
probably somewhat premature to useCallback here?
Contributor
Author
There was a problem hiding this comment.
I suppose it is premature, but we should eventually use usecallback here when we deal with the invite. I don't think adding it now adds to much overhead, and I think it will be a good reminder for the future.
Contributor
Author
There was a problem hiding this comment.
Actually im going to name this handleInvite...to be a little more explicit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
2 new (but related) features:
Practice Mode
When user is using the default config, they will be in practice mode. Practice Mode is indicated by an orange strip across the bottoms of the screen.
Invite to a new Project
With the upcoming refactor of Mapeo core users will have the have a more streamlined approach to join a project.
Users will be able to request to join a project. In Mapeo Desktop, user will be able to join a project through a url or QR code (scanned by the project admin through Mapeo mobile).
Screen Shots
Settings Menu
Practice Mode
Join Project Flow
Linked Sprint Item
Closes #694 #650 #652
To Do