Restore layers on removal from control, improve multilayer support#17
Restore layers on removal from control, improve multilayer support#17RacingTadpole wants to merge 11 commits intodigidem:gh-pagesfrom
Conversation
|
Thanks for this @RacingTadpole. I'm happy with making |
|
@RacingTadpole I tried your PR, but in array layers wasn't working. Are you sure about this PR? |
|
Thanks for checking it out. I could well have missed some cases. Can you give me an example that fails? |
|
It doesn't work the |
|
Thanks @Charmatzis, you're right - eg. the original initialization function no longer worked. I've fixed this now, and made So now This loads the "toner" map with low opacity on the left initially, then after 3 seconds puts it on the right instead. |
|
will this be ever merged ? |
|
Hi, I'd completely forgotten about this. I'd be happy to add contributors if someone would like to review, merge and publish - we're not using this module for any active projects right now so it's not been a priority. |
Fixes #15.
This also improves support for more than one layer on each side (one aspect of which is also addressed by #5).
Note this changes the signature of
_updateLayersto_updateLayers: function (newLeftLayers, newRightLayers). It might also make sense to drop the underscore at the start of its name and makeupdateLayerspart of the API, so you can update both sides' layers in one call.