fix: build international polyfills#1848
Closed
cimigree wants to merge 2 commits intochore/translations-new-structurefrom
Closed
fix: build international polyfills#1848cimigree wants to merge 2 commits intochore/translations-new-structurefrom
cimigree wants to merge 2 commits intochore/translations-new-structurefrom
Conversation
cimigree
changed the title
ErikSin
requested changes
Apr 16, 2026
Contributor
ErikSin
left a comment
ErikSin
left a comment
There was a problem hiding this comment.
We need to add the language code without the regional variant as well so that they can fall back to each other.
Comment on lines
+586
to
+589
| "my-MM": { | ||
| "nativeName": "ဗမာစကာ", | ||
| "englishName": "Burmese (Myanmar)" | ||
| }, |
Contributor
There was a problem hiding this comment.
we should also add the one without the regional variant. For each one that has a regional variant we need to make sure it the one without the regional variant
Contributor
Author
There was a problem hiding this comment.
It was already there:
"my": {
"nativeName": "ဗမာစကာ",
"englishName": "Burmese"
},
Contributor
There was a problem hiding this comment.
Do we also need to add "gu" and "gu-IN"?
Contributor
Author
There was a problem hiding this comment.
We had gu-IN but I added gu
Contributor
Author
|
Also added Mongolian without the region tag. |
Base automatically changed from
chore-update-translations-script-to-use-new-structure
to
chore/translations-new-structure
April 16, 2026 22:48
Contributor
|
Sorry, this was not needed, my bad |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the region tag when building international polyfills.
Most of the changes are just linting based.
Adds Burmese (language of Myanmar) as a possibly language.