Conversation
I think we should delete them, its feels a little redundant at this point |
ErikSin
left a comment
ErikSin
left a comment
There was a problem hiding this comment.
Looks good. I think we should get rid of my "primary-strings" comments and also get rid of the en.json file
Good job with the node extraction script
There was a problem hiding this comment.
we should delete this file
There was a problem hiding this comment.
The build-translations.mjs script still reads from the messages/ folder and en.json is in there. So if we delete it now, the app's English strings would break until step 5. Are you sure we want to do that?
|
Also, it seems like it is just the language e2e tests that are failing. So i think the best strategy is to just comment them out so CI passes since it seems isolated to that |
…in languages where we have it.
* New translations primary.json (French) * New translations secondary.json (Japanese) * New translations secondary.json (Mongolian) * New translations secondary.json (Swahili, Kenya) * New translations secondary.json (Nepali) * New translations secondary.json (Spanish, Latin America)
…t-to-use-new-structure chore: update translations script to use new structure
…e is a key mismatch." This reverts commit 7c62e1b.
chore: new folder and file structure for translations
|
THere is one failing test that is unrelated, so I am merging into develop! |
3 participants
closes #1778
closes #1779
closes #1774
closes #1780
Merged in Erik's PR that has the comments that specify which strings should be primary
Added $1 to the beginning of all of the primary strings
Added an extraction script (in scripts and a command in package.json) to sort the primary strings into a primary file and the rest into a secondary file.
Ran the script and built those files.
Includes a temporary patch for the build-translations file to filter out directories so CI passes
I left the comments in specifying which strings are primary but can easily delete them. What do you think???