fix: sort interfaces according to likely reachability#52
Closed
gmaclennan wants to merge 2 commits intomainfrom
Closed
fix: sort interfaces according to likely reachability#52gmaclennan wants to merge 2 commits intomainfrom
gmaclennan wants to merge 2 commits intomainfrom
Conversation
Member
Author
|
superseded by #53 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
==========================
==========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the
getRemoteBaseUrls()function reads all network interfaces and returns the ipv4 address for all non-internal interfaces, since we don't know which interface may be accessible from the peer device trying to connect.However, we can take a guess at which interface is most likely to be accessible to a peer, and list that one first, which means it will be tried first and hopefully result in faster connections.
This is an attemp to address an issue where an interface
rndis0on Android was being listed first, and is unreachable to the peer, but it was taking 130s to timeout before trying the next IP.rndis0is an interface created by android for USB tethering.