Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #833 +/- ##
==========================================
+ Coverage 40.13% 40.24% +0.11%
==========================================
Files 114 114
Lines 10892 10868 -24
==========================================
+ Hits 4371 4374 +3
+ Misses 6119 6092 -27
Partials 402 402 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Refactors the WSMAN hardware/disk info retrieval path to return typed result structs instead of interface{}/map-based payloads, and updates the devices usecase + tests/mocks accordingly.
Changes:
- Updated WSMAN
ManagementAPIs to returnHWResults/DiskResultsstructs and removed the old map-shaping helpers. - Updated devices usecase DTO conversion to consume typed WSMAN results directly.
- Regenerated/updated mocks and adjusted unit tests to match the new return types.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/usecase/devices/wsman/message_test.go | Removes tests for the deleted physical-memory slice conversion helper. |
| internal/usecase/devices/wsman/message.go | Changes GetHardwareInfo/GetDiskInfo to return typed results; removes map-conversion helpers. |
| internal/usecase/devices/wsman/interfaces.go | Updates Management interface signatures to return typed results. |
| internal/usecase/devices/info.go | Converts typed WSMAN results directly into v1 DTOs (no intermediate maps). |
| internal/usecase/devices/info_test.go | Updates mocks/expectations and expected DTO shapes for HW/Disk info. |
| internal/mocks/wsman_mocks.go | Updates generated gomock stubs for the new typed return values and generation command. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
|
🎉 This PR is included in version 1.22.6 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
No description provided.