fix(skip-link): align caret icon inside skip link panel#2326
Open
rheisler-deque wants to merge 1 commit intodevelopfrom
Open
fix(skip-link): align caret icon inside skip link panel#2326rheisler-deque wants to merge 1 commit intodevelopfrom
rheisler-deque wants to merge 1 commit intodevelopfrom
Conversation
The broad `.SkipLink span` selector was overriding the Icon component's `display: inline-block` to `display: block`, pushing the triangle-right caret onto its own line below the skip link panel. Narrow the selector to only target the SkipLink's own `__item` spans.
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
frankensteinke
approved these changes
Apr 17, 2026
Bracciata
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.SkipLink spanCSS selector was too broad — it matched the Icon component's<span>wrapper and overrode itsdisplay: inline-blocktodisplay: block, pushing the triangle-right caret onto its own line below the skip link panel..SkipLink .SkipLink__item--first, .SkipLink .SkipLink__item--secondso only the SkipLink's own text spans are targeted.Closes: #2276