Open
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes TypeScript typing/discrimination for the React Listbox component so single-select usage works without explicitly providing multiselect, while preserving correct multi-select typing and adding compile-time type coverage.
Changes:
- Introduces an overloaded
ListboxComponenttype to discriminate single-select vs multi-select props. - Adds TypeScript “type test” JSX usages in
Listboxtests to validate valid/invalid prop combinations at compile time. - Updates the
@ts-expect-errorexplanation inActionListto reflect the actual conflicting prop types.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
packages/react/src/components/Listbox/Listbox.tsx |
Replaces the broad polymorphic cast with an overloaded component type for correct single vs multi select prop discrimination. |
packages/react/src/components/Listbox/index.test.tsx |
Adds compile-time type-check examples to ensure the Listbox overloads behave as intended. |
packages/react/src/components/ActionList/ActionList.tsx |
Updates the @ts-expect-error comment to describe the real type conflict when spreading HTML attrs into Listbox. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chornonoh-vova
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1890
PolymorphicComponentcast with a customListboxComponentoverloaded type that properly discriminates between single-select and multi-select variants<Listbox>without explicitly passingmultiselect(single-select is now the default)@ts-expect-errorcomment inActionListto reflect the actual type conflict (HTML attributedefaultValuevsListboxValue)Test plan
tscpasses without errors for single-select<Listbox value="foo">(nomultiselectprop)tsccatches invalid usage (e.g.multiselectwith a string value)