Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Playwright component screenshot coverage for the TextEllipsis React component to prevent visual regressions after recent changes (Issue #2229).
Changes:
- Introduces a new
screenshots.e2e.tsxsuite forTextEllipsiscovering default,maxLines, andhideTooltipvariants. - Adds baseline light/dark screenshot artifacts for each case under
e2e/screenshots/.
Reviewed changes
Copilot reviewed 1 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/react/src/components/TextEllipsis/screenshots.e2e.tsx | New Playwright component screenshot tests for TextEllipsis in light/dark themes. |
| e2e/screenshots/text-ellipsis.png | Baseline screenshot for default TextEllipsis (light). |
| e2e/screenshots/dark--text-ellipsis.png | Baseline screenshot for default TextEllipsis (dark). |
| e2e/screenshots/text-ellipsis-maxLines-.png | Baseline screenshot for TextEllipsis[maxLines] (light). |
| e2e/screenshots/dark--text-ellipsis-maxLines-.png | Baseline screenshot for TextEllipsis[maxLines] (dark). |
| e2e/screenshots/text-ellipsis-hideTooltip-.png | Baseline screenshot for TextEllipsis[hideTooltip] (light). |
| e2e/screenshots/dark--text-ellipsis-hideTooltip-.png | Baseline screenshot for TextEllipsis[hideTooltip] (dark). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Bracciata
changed the title
Bracciata
added
the
update-screenshots
github-actions
bot
removed
the
update-screenshots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2229