Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
c651774 to
a456fdf
Compare
181a91f to
3291620
Compare
sangbooom
approved these changes
Nov 14, 2022
|
|
||
| const onClose = useCallback( | ||
| (event?: MouseEvent<HTMLElement | HTMLButtonElement>) => { | ||
| event && event.stopPropagation(); |
Contributor
There was a problem hiding this comment.
stopPropagation을 넣으신 이유가 어떤 상황을 고려하신건가용?
Collaborator
Author
There was a problem hiding this comment.
제가 잘못 넣었습니다.. 테스트하다가 넣었네요.. 제거했습니다!! 5d8830f
5d8830f to
ef41122
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
바텀시트 하위컴포넌트를 동적으로 변경하기 위해서 useBottomSheet 에 함수를 추가하였습니다.
Changes
useBottomSheet 를 사용하는 방법
페이지 1개에 bottomSheet 하위 컴포넌트가 고정일 때
페이지 1개에 bottomSheet children 이 변경될 수 있을 때
이점 (이라고 생각하는 부분)