test: enable 2 already-passing Node compat tests#33707
test: enable 2 already-passing Node compat tests#33707nathanwhitbot wants to merge 1 commit intodenoland:mainfrom
Conversation
fe26f0d to
ebe93ba
Compare
|
Force-pushed |
nathanwhitbot
left a comment
There was a problem hiding this comment.
Self-review of `ebe93ba1d` (post-cleanup):
Pure config-only test enrollment, no production code. Both entries alphabetically positioned correctly:
| Test | Prev | Next |
|---|---|---|
| `test-startup-empty-regexp-statics.mjs` | `test-stack-size-limit.js` | `test-stdin-child-proc.js` |
| `test-tls-handshake-exception.js` | `test-tls-handshake-error.js` | `test-tls-honorcipherorder.js` |
Both enabled with empty config (`{}`). Body's note about `.mjs` vs `.js` regexp-statics is accurate — the `.mjs` test only validates static `RegExp.$_`/`$1`/etc. defaults without spawning a `deno -p` subprocess that the `.js` version uses. Holding to COMMENT until CI confirms.
nathanwhitbot
left a comment
There was a problem hiding this comment.
Single-commit, 2-line config-only enrollment. No scope-creep. LGTM — TLS handshake test can be timing-sensitive on slower runners; if either test comes back red on Windows or macOS drop rather than gate.
|
Both tests in this PR fail on
Drop both per @bartlomieju's convention. (Shard 2/3 failure on |
|
Closing — both enabled tests fail on |
Summary
Enables 2 Node.js compat tests that already pass on main without any code changes. No production code touched — just
tests/node_compat/config.jsoncentries.parallel/test-startup-empty-regexp-statics.mjsparallel/test-tls-handshake-exception.jsThe
.mjsregexp-statics test (unlike its.jssibling) skips the failingdeno -pspawn assertion and only checks the staticRegExp.$_/RegExp.$1/ etc. defaults — which Deno gets right.Test plan
cargo test --test node_compatrun on Linux confirms no regressions (only pre-existing flaky failures)