test: enable 2 already-passing Node compat tests#33706
test: enable 2 already-passing Node compat tests#33706bartlomieju merged 1 commit intodenoland:mainfrom
Conversation
ad0230e to
aaecedd
Compare
|
Force-pushed |
nathanwhitbot
left a comment
There was a problem hiding this comment.
Self-review of `aaeceddb3` (post-cleanup):
Pure config-only test enrollment, no production code. Both entries alphabetically positioned correctly:
| Test | Prev | Next |
|---|---|---|
| `test-tls-junk-closes-server.js` | `test-tls-js-stream.js` | `test-tls-keyengine-invalid-arg-type.js` |
| `test-tls-no-rsa-key.js` | `test-tls-no-cert-required.js` | `test-tls-no-sslv3.js` |
Both enabled with empty config (`{}`). Holding to COMMENT until CI confirms.
nathanwhitbot
left a comment
There was a problem hiding this comment.
Single-commit, 2-line config-only enrollment. No scope-creep. LGTM — TLS tests can be platform-sensitive, so if either comes back red on Windows or macOS drop rather than gate.
|
|
fibibot
left a comment
There was a problem hiding this comment.
LGTM. Pure config-only enrollment, 2 entries, both alphabetically positioned correctly:
test-tls-junk-closes-server.jsbetweentest-tls-js-streamandtest-tls-keyengine-invalid-arg-type(j-s<j-u-nk<k). ✓test-tls-no-rsa-key.jsbetweentest-tls-no-cert-requiredandtest-tls-no-sslv3(no-c<no-r<no-s). ✓
CI: 128 success, 1 substantive failure, 3 still pending. The single failure (test integration (1/2) debug macos-aarch64) is a rustup-channel-download DNS error during build setup:
error: could not download file from 'https://static.rust-lang.org/dist/channel-rust-1.92.0.toml.sha256'
3: dns error
4: failed to lookup address information: nodename nor servname provided, or not known
The shard never reached the test phase, and a config-only PR can't cause a DNS lookup to fail. Pure infra flake.
Summary
Enables 2 Node.js compat tests that already pass on main without any code changes. No production code touched — just
tests/node_compat/config.jsoncentries.parallel/test-tls-junk-closes-server.jsparallel/test-tls-no-rsa-key.jsTest plan
cargo test --test node_compatrun on Linux confirms no regressions (only pre-existing flaky failures)