Skip to content

test: enable 3 already-passing Node compat tests#33687

Merged
nathanwhit merged 1 commit intodenoland:mainfrom
nathanwhitbot:fix/node-compat-iter70
Apr 29, 2026
Merged

test: enable 3 already-passing Node compat tests#33687
nathanwhit merged 1 commit intodenoland:mainfrom
nathanwhitbot:fix/node-compat-iter70

Conversation

@nathanwhitbot
Copy link
Copy Markdown
Contributor

Summary

Enables 3 Node.js compat tests that already pass on main without any code changes. No production code touched — just tests/node_compat/config.jsonc entries.

  • parallel/test-http2-misbehaving-multiplex.js
  • parallel/test-http2-server-http1-client.js
  • parallel/test-tls-socket-close.js

Test plan

  • Each test verified passing 3/3 times via the node_compat test runner
  • Full cargo test --test node_compat run on Linux confirms no regressions (only pre-existing flaky failures)

@nathanwhitbot nathanwhitbot force-pushed the fix/node-compat-iter70 branch from b5f0fce to 3ed71f3 Compare April 29, 2026 11:06
@nathanwhitbot
Copy link
Copy Markdown
Contributor Author

Force-pushed 3ed71f30c — branch was stacked on top of #33653's commits as a base instead of upstream/main, so the diff was including all of #33653's content (cluster tests, http tests, etc.). Reset to upstream/main and cherry-picked just the 3-test commit. Diff is now 1 file, +3 -0.

Copy link
Copy Markdown
Contributor Author

@nathanwhitbot nathanwhitbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review of `3ed71f30c` (post-cleanup):

Pure config-only test enrollment, no production code. All 3 entries alphabetically positioned correctly:

Test Prev Next
`test-http2-misbehaving-multiplex.js` `test-http2-methods.js` `test-http2-misc-util.js`
`test-http2-server-http1-client.js` `test-http2-server-errors.js` `test-http2-server-rfc-9113-server.js`
`test-tls-socket-close.js` `test-tls-socket-allow-half-open-option.js` `test-tls-socket-constructor-alpn-options-parsing.js`

All three enabled with empty config (`{}`), so no per-platform gates or flaky markers. Holding to COMMENT until CI confirms.

Copy link
Copy Markdown
Contributor Author

@nathanwhitbot nathanwhitbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single-commit, 3-line config-only change. No scope-creep. LGTM — hold for cross-platform CI per usual; if any of the http2/tls tests come back red on Windows or macOS, drop rather than gate.

Copy link
Copy Markdown
Contributor

@fibibot fibibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pure config-only enrollment, 3 entries:

  • test-http2-misbehaving-multiplex.js — slotted between test-http2-methods and test-http2-misc-util (methods < misbehaving < misc). ✓
  • test-http2-server-http1-client.js — between test-http2-server-errors and test-http2-server-rfc-9113-server (errors < http1-client < rfc-9113). ✓
  • test-tls-socket-close.js — between test-tls-socket-allow-half-open-option and test-tls-socket-constructor-alpn-options-parsing (allow < close < constructor). ✓

CI fully green: 133 SUCCESS, 0 FAILURE, 2 SKIPPED. All test node_compat shards across 6 platforms × debug+release pass.

@nathanwhit nathanwhit merged commit d36b1ec into denoland:main Apr 29, 2026
136 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants