test: enable 3 already-passing Node compat tests#33687
Merged
nathanwhit merged 1 commit intodenoland:mainfrom Apr 29, 2026
Merged
test: enable 3 already-passing Node compat tests#33687nathanwhit merged 1 commit intodenoland:mainfrom
nathanwhit merged 1 commit intodenoland:mainfrom
Conversation
b5f0fce to
3ed71f3
Compare
Contributor
Author
nathanwhitbot
commented
Apr 29, 2026
Contributor
Author
nathanwhitbot
left a comment
There was a problem hiding this comment.
Self-review of `3ed71f30c` (post-cleanup):
Pure config-only test enrollment, no production code. All 3 entries alphabetically positioned correctly:
| Test | Prev | Next |
|---|---|---|
| `test-http2-misbehaving-multiplex.js` | `test-http2-methods.js` | `test-http2-misc-util.js` |
| `test-http2-server-http1-client.js` | `test-http2-server-errors.js` | `test-http2-server-rfc-9113-server.js` |
| `test-tls-socket-close.js` | `test-tls-socket-allow-half-open-option.js` | `test-tls-socket-constructor-alpn-options-parsing.js` |
All three enabled with empty config (`{}`), so no per-platform gates or flaky markers. Holding to COMMENT until CI confirms.
nathanwhitbot
commented
Apr 29, 2026
Contributor
Author
nathanwhitbot
left a comment
There was a problem hiding this comment.
Single-commit, 3-line config-only change. No scope-creep. LGTM — hold for cross-platform CI per usual; if any of the http2/tls tests come back red on Windows or macOS, drop rather than gate.
fibibot
approved these changes
Apr 29, 2026
Contributor
fibibot
left a comment
There was a problem hiding this comment.
LGTM. Pure config-only enrollment, 3 entries:
test-http2-misbehaving-multiplex.js— slotted betweentest-http2-methodsandtest-http2-misc-util(methods<misbehaving<misc). ✓test-http2-server-http1-client.js— betweentest-http2-server-errorsandtest-http2-server-rfc-9113-server(errors<http1-client<rfc-9113). ✓test-tls-socket-close.js— betweentest-tls-socket-allow-half-open-optionandtest-tls-socket-constructor-alpn-options-parsing(allow<close<constructor). ✓
CI fully green: 133 SUCCESS, 0 FAILURE, 2 SKIPPED. All test node_compat shards across 6 platforms × debug+release pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables 3 Node.js compat tests that already pass on main without any code changes. No production code touched — just
tests/node_compat/config.jsoncentries.parallel/test-http2-misbehaving-multiplex.jsparallel/test-http2-server-http1-client.jsparallel/test-tls-socket-close.jsTest plan
cargo test --test node_compatrun on Linux confirms no regressions (only pre-existing flaky failures)