Skip to content

fix(ext/node): emit DEP0174 when util.promisify wraps a Promise-returning function #33662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nathanwhitbot wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −2
Open

fix(ext/node): emit DEP0174 when util.promisify wraps a Promise-returning function #33662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ext/node/polyfills/internal/util.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
import { ERR_UNKNOWN_SIGNAL } from "ext:deno_node/internal/errors.ts";
import { os } from "ext:deno_node/internal_binding/constants.ts";
import { primordials } from "ext:core/mod.js";
import { isNativeError } from "ext:deno_node/internal/util/types.ts";
import { isNativeError, isPromise } from "ext:deno_node/internal/util/types.ts";

// deno-lint-ignore prefer-primordials
const AtomicsWait = Atomics.wait;
Expand Down Expand Up @@ -119,7 +119,13 @@ export function promisify(
resolve(values[0]);
}
});
ReflectApply(original, this, args);
if (isPromise(ReflectApply(original, this, args))) {
globalThis.process.emitWarning(
"Calling promisify on a function that returns a Promise is likely a mistake.",
"DeprecationWarning",
"DEP0174",
);
}
});
}

Expand Down
1 change: 1 addition & 0 deletions tests/node_compat/config.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3248,6 +3248,7 @@
"parallel/test-util-parse-env.js": {},
"parallel/test-util-primordial-monkeypatching.js": {},
"parallel/test-util-promisify-custom-names.mjs": {},
"parallel/test-util-promisify.js": {},
"parallel/test-util-stripvtcontrolcharacters.js": {},
"parallel/test-util-styletext.js": {},
"parallel/test-util-text-decoder.js": {},
Expand Down
Loading