fix(ext/node): use ERR_INVALID_ARG_TYPE for tls.createServer non-object options#33589
Merged
bartlomieju merged 1 commit intodenoland:mainfrom Apr 27, 2026
Merged
Conversation
…ct options
`tls.createServer('not an object')` was throwing a plain
`TypeError: options must be an object` with no `code` set. Match
Node's [`lib/_tls_wrap.js`](https://github.com/nodejs/node/blob/main/lib/_tls_wrap.js)
by raising `ERR_INVALID_ARG_TYPE` so consumers see
`code: 'ERR_INVALID_ARG_TYPE'` and the standard message
`The "options" argument must be of type object. Received type string ('not an object')`.
Enables `parallel/test-tls-no-cert-required.js`.
bartlomieju
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tls.createServer('this is not valid')was throwing a plainTypeError("options must be an object")with nocodeset. Match Node'slib/_tls_wrap.jsso the rejection carries:code: 'ERR_INVALID_ARG_TYPE'message: 'The "options" argument must be of type object. Received type string (\'this is not valid\')'Enables
parallel/test-tls-no-cert-required.js.Test plan
cargo test --test node_compat -- test-tls-no-cert-required(was failing on main, passes here)cargo build --bin denocleantools/format.jsandtools/lint.js --jscleantest-tls-basic-validations,test-tls-startcom-wosign-whitelist,test-tls-honorcipherorder,test-tls-add-context,test-tls-cert-regression,test-tls-check-server-identity.