test: enable 9 already-passing Node compat tests#33582
Open
nathanwhitbot wants to merge 1 commit intodenoland:mainfrom
Open
test: enable 9 already-passing Node compat tests#33582nathanwhitbot wants to merge 1 commit intodenoland:mainfrom
nathanwhitbot wants to merge 1 commit intodenoland:mainfrom
Conversation
All 9 tests pass against current main with no code changes; this just adds them to config.jsonc so they're tracked. Each was verified via `cargo test --test node_compat -- <name>` and re-run three times to rule out flakiness. parallel/test-als-defaultvalue.js parallel/test-fastutf8stream-destroy.js parallel/test-fs-readdir-buffer.js parallel/test-http2-backpressure.js parallel/test-http2-close-while-writing.js parallel/test-http2-server-sessionerror.js parallel/test-https-abortcontroller.js parallel/test-tcp-wrap-connect.js parallel/test-tls-add-context.js
nathanwhitbot
commented
Apr 27, 2026
Contributor
Author
nathanwhitbot
left a comment
nathanwhitbot
left a comment
There was a problem hiding this comment.
Config-only — 9 additive {} entries. Spot-checked the trickier ASCII
placements:
test-fs-readdir-buffer.jsaftertest-fs-read.js— correct because
.(0x2e) <d(0x64), soread.js<readdir-….test-http2-server-sessionerror.jsafter…-server-session-destroy.js
—-(0x2d) <e(0x65), sosession-…<sessionerror.test-https-abortcontroller.jsafter the http2 block, before
…-agent-abort-controller.js—2<sseparateshttp2and
https, thenb<gseparatesabortfromagent.
All 9 land in the right slot. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables 9 Node.js compat tests that already pass on main without any code changes. No production code touched — just
tests/node_compat/config.jsoncentries.parallel/test-als-defaultvalue.jsparallel/test-fastutf8stream-destroy.jsparallel/test-fs-readdir-buffer.jsparallel/test-http2-backpressure.jsparallel/test-http2-close-while-writing.jsparallel/test-http2-server-sessionerror.jsparallel/test-https-abortcontroller.jsparallel/test-tcp-wrap-connect.jsparallel/test-tls-add-context.jsTest plan
cargo test --test node_compat -- <name>(9/9 pass)