fix(ext/node): align node stream destroy named export#33573
fix(ext/node): align node stream destroy named export#33573ktKongTong wants to merge 1 commit intodenoland:mainfrom
destroy named export#33573Conversation
fibibot
left a comment
There was a problem hiding this comment.
LGTM. Verified against Node's lib/stream.js — Node's public API is Stream.destroy = destroyer (the implementation is named destroyer internally, but the export surface is destroy). So import { destroy } from 'node:stream' is the correct Node form, and destroyer was a Deno-specific divergence. Renaming the named export to destroy matches Node and keeps the existing Stream.destroy = destroyer assignment on line 126 consistent with the new export.
One observation inline: dropping the destroyer export name entirely is technically a breaking change for any Deno-specific code that imported destroyer from node:stream — though that name never existed in Node, so realistically very few users would have written that. Searched tests/, ext/ and found zero internal usages, so internally clean.
No CI signal yet (the PR is from an external contributor — only lint title and CLA have run; full CI needs a maintainer to authorize), but the change is so small that visual review covers it.
align node:stream
destroynamed exportExpect Output:
functionActual Output:
Uncaught SyntaxError: The requested module 'node:stream' does not provide an export named 'destroy'