Skip to content

feat: change default fuzziness from AUTO to 0 in OpenSearch retrievers #3198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SyedShahmeerAli12 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: change default fuzziness from AUTO to 0 in OpenSearch retrievers #3198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...s/opensearch/src/haystack_integrations/components/retrievers/opensearch/bm25_retriever.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def __init__(
*,
document_store: OpenSearchDocumentStore,
filters: dict[str, Any] | None = None,
fuzziness: int | str = "AUTO",
fuzziness: int | str = 0,
top_k: int = 10,
scale_score: bool = False,
all_terms_must_match: bool = False,
Expand Down
2 changes: 1 addition & 1 deletion ...rc/haystack_integrations/components/retrievers/opensearch/open_search_hybrid_retriever.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def __init__(
embedder: TextEmbedder,
# OpenSearchBM25Retriever
filters_bm25: dict[str, Any] | None = None,
fuzziness: int | str = "AUTO",
fuzziness: int | str = 0,
top_k_bm25: int = 10,
scale_score: bool = False,
all_terms_must_match: bool = False,
Expand Down
4 changes: 2 additions & 2 deletions ...rations/opensearch/src/haystack_integrations/document_stores/opensearch/document_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1057,7 +1057,7 @@ def _bm25_retrieval(
query: str,
*,
filters: dict[str, Any] | None = None,
fuzziness: int | str = "AUTO",
fuzziness: int | str = 0,
top_k: int = 10,
scale_score: bool = False,
all_terms_must_match: bool = False,
Expand Down Expand Up @@ -1115,7 +1115,7 @@ async def _bm25_retrieval_async(
query: str,
*,
filters: dict[str, Any] | None = None,
fuzziness: str = "AUTO",
fuzziness: int | str = 0,
top_k: int = 10,
scale_score: bool = False,
all_terms_must_match: bool = False,
Expand Down
10 changes: 5 additions & 5 deletions integrations/opensearch/tests/test_bm25_retriever.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def test_to_dict(_mock_opensearch_client):
"type": "haystack_integrations.document_stores.opensearch.document_store.OpenSearchDocumentStore",
},
"filters": {},
"fuzziness": "AUTO",
"fuzziness": 0,
"top_k": 10,
"scale_score": False,
"filter_policy": "replace",
Expand Down Expand Up @@ -163,7 +163,7 @@ def test_run():
mock_store._bm25_retrieval.assert_called_once_with(
query="some query",
filters={},
fuzziness="AUTO",
fuzziness=0,
top_k=10,
scale_score=False,
all_terms_must_match=False,
Expand All @@ -183,7 +183,7 @@ async def test_run_async():
mock_store._bm25_retrieval_async.assert_called_once_with(
query="some query",
filters={},
fuzziness="AUTO",
fuzziness=0,
top_k=10,
scale_score=False,
all_terms_must_match=False,
Expand Down Expand Up @@ -359,7 +359,7 @@ def test_run_with_runtime_document_store():
runtime_store._bm25_retrieval.assert_called_once_with(
query="some query",
filters={},
fuzziness="AUTO",
fuzziness=0,
top_k=10,
scale_score=False,
all_terms_must_match=False,
Expand Down Expand Up @@ -390,7 +390,7 @@ async def test_run_async_with_runtime_document_store():
runtime_store._bm25_retrieval_async.assert_called_once_with(
query="some query",
filters={},
fuzziness="AUTO",
fuzziness=0,
top_k=10,
scale_score=False,
all_terms_must_match=False,
Expand Down
6 changes: 3 additions & 3 deletions integrations/opensearch/tests/test_open_search_hybrid_retriever.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ class TestOpenSearchHybridRetriever:
},
},
"filters_bm25": None,
"fuzziness": "AUTO",
"fuzziness": 0,
"top_k_bm25": 10,
"scale_score": False,
"all_terms_must_match": False,
Expand Down Expand Up @@ -227,7 +227,7 @@ def test_run_with_extra_runtime_params(self, mock_embedder):
filters={"key": "value"},
top_k=1,
all_terms_must_match=False,
fuzziness="AUTO",
fuzziness=0,
scale_score=False,
custom_query=None,
)
Expand Down Expand Up @@ -260,7 +260,7 @@ def test_run_in_pipeline(self, mock_embedder):
filters={"param_a": "default"},
top_k=10,
all_terms_must_match=False,
fuzziness="AUTO",
fuzziness=0,
scale_score=False,
custom_query=None,
)
Expand Down
Loading