Skip to content

refactor!: Elasticsearch - use async mixin tests and fix write/delete behaviour #3196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anakin87 merged 14 commits into from
Apr 22, 2026
+147 −443
Merged

refactor!: Elasticsearch - use async mixin tests and fix write/delete behaviour #3196

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
9c31bfe
refactor(elasticsearch): use async DocumentStore mixin tests
SyedShahmeerAli12 Apr 21, 2026
cfab227
fix(elasticsearch): fix E501 and override test_count_not_empty_async
SyedShahmeerAli12 Apr 21, 2026
9280fa3
fix(elasticsearch): override delete mixin tests to match ES error beh…
SyedShahmeerAli12 Apr 21, 2026
69a4a8d
fix(elasticsearch): override duplicate fail mixin test to match ES er…
SyedShahmeerAli12 Apr 21, 2026
cd04a3d
fix(elasticsearch): override duplicate skip mixin test — ES returns 1…
SyedShahmeerAli12 Apr 21, 2026
fc8b5c1
fix(elasticsearch): fix async write/delete bugs and restore comments
SyedShahmeerAli12 Apr 22, 2026
84dc468
fix(elasticsearch): use create op for SKIP policy to enable proper sk…
SyedShahmeerAli12 Apr 22, 2026
f4c463d
test(elasticsearch): restore inline comments in test_embedding_retrie…
SyedShahmeerAli12 Apr 22, 2026
7d17a71
test(elasticsearch): restore all removed comments and docstrings in a…
SyedShahmeerAli12 Apr 22, 2026
a10dcae
Merge branch 'main' into refactor/elasticsearch-async-mixin-tests
davidsbatista Apr 22, 2026
9737b86
fixin Mixin tests and write/delete docs asyn operations
davidsbatista Apr 22, 2026
8ee9f3f
reverting try/catch on write/delete operations - aligning with other…
davidsbatista Apr 22, 2026
35fb0a8
restoring some of the comments
davidsbatista Apr 22, 2026
ed4fa82
Merge branch 'main' into refactor/elasticsearch-async-mixin-tests
davidsbatista Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion integrations/elasticsearch/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ classifiers = [
"Programming Language :: Python :: Implementation :: PyPy",
]
dependencies = [
"haystack-ai>=2.26.1",
"haystack-ai>=2.28.0",
"elasticsearch>=8,<9",
"aiohttp>=3.9.0" # for async support https://elasticsearch-py.readthedocs.io/en/latest/async.html#valueerror-when-initializing-asyncelasticsearch
]
Expand Down
Loading
Loading