fix(listen): warn when keywords is used with nova-3 model#480
Open
peteroyce wants to merge 1 commit intodeepgram:mainfrom
Open
fix(listen): warn when keywords is used with nova-3 model#480peteroyce wants to merge 1 commit intodeepgram:mainfrom
peteroyce wants to merge 1 commit intodeepgram:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #474
Adds a runtime
console.warn()inWrappedListenV1Client.connect()when the caller passes bothkeywordsand a nova-3 model (nova-3,nova-3-general,nova-3-medical). The Deepgram API silently rejects this combination with an HTTP 400, making it very hard to diagnose.Before: The WebSocket upgrade fails with a bare HTTP 400 — no feedback to the developer.
After: A clear warning is printed before the connection attempt:
Why
CustomClient.ts: This file is not auto-generated by Fern and will survive SDK regenerations. The check is placed before the WebSocket is created so developers see the warning immediately.No breaking changes — this is a warning only, existing behavior is unchanged.