Open
Conversation
This removes all support for automatic port mapping via UPnP. A warning
will now be shown if the CLI flag is specified that it is no longer
supported.
The primary motivations for removing it are:
- Automatic port mapping via UPnP has always been controversial due to its
security implications
- It has always been disabled by default due to the aforementioned
security implications and thus very few people ever used it
- UPnP is increasingly less relevant than it was over a decade ago and
has very low real world utility today
- The existing support only ever worked on a limited amount of devices
as is typical of UPnP in general due to most routers not implementing
the spec properly
- Any perceived convenience realistically no longer applies today
because, due to many security issues over the years with the protocol,
including some as recent as 2026, nearly all modern routers come with
it disabled by default
- If a user is capable of enabling UPnP on the router, they are
equally capable of just mapping the port themselves
- Manual port forwarding is straightforward and far more secure
- IPv6 is increasingly more common where UPnP is irrelevant
Given all of the aforementioned, it really isn't worth the maintenance
burden anymore.
3467a06 to
6c30e8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes all support for automatic port mapping via UPnP. A warning will now be shown if the CLI flag is specified that it is no longer supported.
The primary motivations for removing it are:
Given all of the aforementioned, it really isn't worth the maintenance burden anymore.