connmgr: Improve accuracy of a couple of tests.#3642
Open
davecgh wants to merge 2 commits intodecred:masterfrom
Open
connmgr: Improve accuracy of a couple of tests.#3642davecgh wants to merge 2 commits intodecred:masterfrom
davecgh wants to merge 2 commits intodecred:masterfrom
Conversation
jholdstock
reviewed
Mar 11, 2026
Member
jholdstock
left a comment
jholdstock
left a comment
There was a problem hiding this comment.
File copyright year is not updated, otherwise lgtm
davecgh
force-pushed
the
connmgr_test_accuracy
branch
from
358fdee to
113474d
Compare
Member
Author
Thanks. I rebased it over master where it was already updated. It should be good to go now. |
jholdstock
approved these changes
Mar 11, 2026
This makes TestPassAddrAlongDialAddr more accurate by explicitly detecting the dailed address directly in the provided dialer as opposed to from the conn request object of the mock connection. An invalid address, such as the one that is used in the test, would never result in a valid connection.
This reworks the TestTargetOutbound test a bit to ensure it fails if the expected number of connections are not made within a certain timeout. The prevents a test timeout in the failure case.
davecgh
force-pushed
the
connmgr_test_accuracy
branch
from
113474d to
acfafa2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This consists of two commits which improve the accuracy of a couple of tests.
The first commit makes
TestPassAddrAlongDialAddrmore accurate by explicitly detecting the dailed address directly in the provided dialer as opposed to from the conn request object of the mock connection.An invalid address, such as the one that is used in the test, would never result in a valid connection.
The second commit reworks the
TestTargetOutboundtest a bit to ensure it fails if the expected number of connections are not made within a certain timeout. The prevents a test timeout in the failure case.