Skip to content

v3.0.5 #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddc merged 1 commit into from
Feb 25, 2026
Merged

v3.0.5 #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/gw2/cogs/sessions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,10 +251,7 @@ def _add_wvw_stats(embed: discord.Embed, rs_start: dict, rs_end: dict) -> None:
end_val = rs_end[stat_key]
if start_val != end_val:
diff = end_val - start_val
if stat_key == "wvw_rank":
embed.add_field(name=field_name, value=chat_formatting.inline(str(diff)))
else:
embed.add_field(name=field_name, value=chat_formatting.inline(f"+{diff}" if diff > 0 else str(diff)))
embed.add_field(name=field_name, value=chat_formatting.inline(str(diff)))


def _add_wallet_currency_fields(embed: discord.Embed, rs_start: dict, rs_end: dict) -> None:
Expand Down
5 changes: 2 additions & 3 deletions tests/unit/gw2/cogs/test_sessions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -944,12 +944,11 @@ def test_all_stats_changed(self):
with patch("src.gw2.cogs.sessions.chat_formatting.inline", side_effect=lambda x: f"`{x}`"):
_add_wvw_stats(embed, start, end)
assert len(embed.fields) == 8
# wvw_rank should not have + sign (rank can only increase)
# WvW stats should not have + sign (they can only increase)
rank_field = next(f for f in embed.fields if f.name == gw2_messages.WVW_RANKS)
assert rank_field.value == "`2`"
# other stats should have + sign
yaks_field = next(f for f in embed.fields if f.name == gw2_messages.YAKS_KILLED)
assert yaks_field.value == "`+3`"
assert yaks_field.value == "`3`"

def test_no_stats_changed(self):
embed = discord.Embed()
Expand Down