Conversation
|
@ThibaudDauce this looks pretty good, thanks. Re integration downstream: I'll have a challenge injecting the right filter templates depending on which site is visited. In #1034 it was simply a matter of building a site-aware conf and passing it, now I need dynamic templates somehow (I hope I'll be able to keep everything in config on downstream side at least). BTW, this PR breaks the "everything in config" paradigm we had before. But I agree it's more powerful and will be able to handle more use cases in the future (which I don't have in mind right now). I'll try to integrate in opendatateam/udata-front-kit#1153 and let you know how that goes. |
1cc8b03 to
d250a81
Compare
d250a81 to
20baee9
Compare
|
@ThibaudDauce can you port the styles modifications here? https://github.com/datagouv/cdata/pull/1034/changes#diff-e8eff0975d30ae4013561b11a589489938009a4fda06462ab26128b2d38761f9 It lets downstream have the style for |
Done in 225c146 |
You can test it on http://dev.local:3000/design/dataset-search
Replace #1034