Skip to content

feat: search custom filters#1048

Open
ThibaudDauce wants to merge 4 commits intomainfrom
search-custom-filters
Open

feat: search custom filters#1048
ThibaudDauce wants to merge 4 commits intomainfrom
search-custom-filters

Conversation

@ThibaudDauce
Copy link
Copy Markdown
Contributor

@ThibaudDauce ThibaudDauce commented Apr 15, 2026

@abulte
Copy link
Copy Markdown
Contributor

abulte commented Apr 16, 2026

@ThibaudDauce this looks pretty good, thanks.

Re integration downstream: I'll have a challenge injecting the right filter templates depending on which site is visited. In #1034 it was simply a matter of building a site-aware conf and passing it, now I need dynamic templates somehow (I hope I'll be able to keep everything in config on downstream side at least). BTW, this PR breaks the "everything in config" paradigm we had before.

But I agree it's more powerful and will be able to handle more use cases in the future (which I don't have in mind right now). I'll try to integrate in opendatateam/udata-front-kit#1153 and let you know how that goes.

Comment thread datagouv-components/src/composables/useStableQueryParams.ts
@ThibaudDauce ThibaudDauce force-pushed the search-custom-filters branch from 1cc8b03 to d250a81 Compare April 16, 2026 08:18
@abulte
Copy link
Copy Markdown
Contributor

abulte commented Apr 16, 2026

@ThibaudDauce
Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants