Add sharded cloud acceptance test entry point#4743
Draft
shreyas-goenka wants to merge 1 commit intomainfrom
Draft
Add sharded cloud acceptance test entry point#4743shreyas-goenka wants to merge 1 commit intomainfrom
shreyas-goenka wants to merge 1 commit intomainfrom
Conversation
Add `TestAcceptCloudSharded` which reads `TOTAL_SHARDS` and `SHARD_INDEX` environment variables to deterministically assign acceptance tests to shards using FNV-1a hashing. This enables parallel CI execution of cloud tests across multiple runners without overlap or gaps. The existing `TestAccept` code path is unchanged. Co-authored-by: Isaac
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 704fcee
21 interesting tests: 7 KNOWN, 7 SKIP, 5 flaky, 1 RECOVERED, 1 BUG
Top 25 slowest tests (at least 2 minutes):
|
denik
reviewed
Mar 19, 2026
| // (identified by its dir + env variant name) is assigned to exactly one shard | ||
| // via FNV-1a hashing, so all shards together cover the full test suite with no | ||
| // overlap. | ||
| func TestAcceptCloudSharded(t *testing.T) { |
Contributor
There was a problem hiding this comment.
Should we just modify TestAccept to respect the env vars if present?
| var shardConfig *shardingConfig | ||
|
|
||
| // TestAcceptCloudSharded runs a deterministic subset of cloud acceptance tests | ||
| // based on TOTAL_SHARDS and SHARD_INDEX environment variables. Each test |
Contributor
There was a problem hiding this comment.
nit: Common prefix would be useful to indicate that these are related: TEST_SHARD_TOTAL TEST_SHARD_INDEX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestAcceptCloudSharded- a new sharded acceptance test entry point that readsTOTAL_SHARDS/SHARD_INDEXenvironment variables and uses FNV-1a hashing to deterministically assign tests to shards.TestAccept- the existing pipeline is untouched.Test plan
TestAcceptCloudShardedlocally withTOTAL_SHARDS=3 SHARD_INDEX=0and verify only a subset of tests execute.TestAcceptcontinues to work unchanged without the sharding env vars.