Fixed RxBleAdapterStateObservable leak.#864
Merged
dariuszseweryn merged 1 commit intomasterfrom Jun 4, 2025
Merged
Conversation
dariuszseweryn
force-pushed
the
fix/bleadapterstate_leak
branch
from
4b0fd9b to
0e70169
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause: the DisconnectionRouter did not properly cleaned up its state as long as neither the BluetoothGattCallback signalled a disconnection or Android did broadcast change in the BluetoothAdapter state. For cases when the connection unsubscription happened before the BluetoothGatt did started to connect (before BluetoothGattCallback#onConnectionStateChange was called, <~50 milliseconds) neither of these cases had place, causing a leak.
Fixes #851