Skip to content

fix flaky standalone e2e by dropping "Exited App successfully" requirement #1605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
acroca wants to merge 5 commits into
base: master
Choose a base branch
from
+42 −11
Open

fix flaky standalone e2e by dropping "Exited App successfully" requirement #1605

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a962840
fix flaky standalone e2e by dropping "Exited App successfully" requir…
acroca Mar 6, 2026
00c8155
consume stderr in e2e tests
acroca Mar 6, 2026
6a053d3
Address copilot comments
acroca Mar 6, 2026
ef804ff
Address copilot comments
acroca Mar 6, 2026
946f49f
Address copilot comments
acroca Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions tests/e2e/standalone/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,21 +117,17 @@ func executeAgainstRunningDapr(t *testing.T, f func(), daprArgs ...string) {
}

err := cmd.Wait()
hasAppCommand := !strings.Contains(daprOutput, "WARNING: no application command found")
if err != nil {
var exitErr *exec.ExitError
if errors.As(err, &exitErr) && exitErr.ExitCode() == 1 &&
strings.Contains(daprOutput, "Exited Dapr successfully") &&
(!hasAppCommand || strings.Contains(daprOutput, "Exited App successfully")) {
!strings.Contains(daprOutput, "The App process exited with error code: exit status") {
err = nil
}
}
require.NoError(t, err, "dapr didn't exit cleanly")
assert.NotContains(t, daprOutput, "The App process exited with error code: exit status", "Stop command should have been called before the app had a chance to exit")
assert.Contains(t, daprOutput, "Exited Dapr successfully")
if hasAppCommand {
assert.Contains(t, daprOutput, "Exited App successfully")
}
}

// ensureDaprInstallation ensures that Dapr is installed.
Expand Down
Loading