Skip to content

Fix unwanted container recreation caused by label drift in staker daemon #2413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Marketen wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix unwanted container recreation caused by label drift in staker daemon #2413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/dockerCompose/src/userSettings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,9 +236,14 @@ export function applyUserSettings(
);
// ##### </DEPRECATED>

const existingLabels = service.labels || {};
const newDefaultLabels = writeDefaultsToLabels(pick(service, ["environment", "ports", "volumes"]));
const nextLabels = {
...(service.labels || {}),
...writeDefaultsToLabels(pick(service, ["environment", "ports", "volumes"]))
// New defaults as base layer (only matters on first install when no labels exist)
...newDefaultLabels,
// Existing labels take precedence, preserving original package defaults
// and preventing label drift when the daemon re-applies user settings
...existingLabels
};

return {
Expand Down
Loading