Fix: Stop auto-connect from retrying when blocked by Android#460
Merged
Conversation
BluetoothHeadset.connect() requires MODIFY_PHONE_STATE on modern Android, which is a system-only permission. Detect the SecurityException and stop further attempts instead of retrying every second.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Fixed auto-connect repeatedly failing every second on newer Android versions. The app now detects when the connection method is blocked by the OS and stops retrying. Also added a note in the setting description that this feature may not work on newer Android versions.
Technical Context
BluetoothHeadset.connect()is a hidden API that now requiresMODIFY_PHONE_STATE— a system-only permission that third-party apps cannot obtain. Confirmed on both Samsung S22 Ultra and Pixel 8 running Android 16.nudgeConnectionwas silently returningfalsewithout distinguishing permanent from transient failures. AutoConnect would retry on every BLE scan result (~1s), spamming the same SecurityException indefinitely.SecurityException(direct or wrapped inInvocationTargetException) and setsisNudgeAvailable = falsefor the process lifetime. AutoConnect checks this flag before callingnudgeConnection.