Fix: Prevent crash from dependency injection failure in monitoring service#458
Merged
Fix: Prevent crash from dependency injection failure in monitoring service#458
Conversation
Wrap super.onCreate() (Hilt injection) in try-catch to prevent DI failures from crashing the process. The service is already foreground at this point, so a graceful stopSelf() satisfies the FGS timeout requirement without killing the app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Prevented a potential crash that could happen if the monitoring service's dependency injection fails during startup. Instead of crashing the entire app, the service now stops gracefully and reports the error.
Technical Context
MonitorService.onCreate()already callsstartForeground()beforesuper.onCreate()(Hilt DI) to satisfy the FGS timeout. However, if DI then throws (e.g.,SecurityExceptionfrom Bluetooth access, DataStore I/O failure, or the app being started in a restricted context like backup/restore), the unhandled exception crashes the process.super.onCreate()in try-catch lets the service stop cleanly viastopSelf()while the foreground notification is still up — satisfying the system's FGS requirement without killing the app.Bugs.report()so it surfaces in crash analytics rather than being silently swallowed.App.onCreate().