Fix: Fix native crash when displaying battery levels#457
Merged
Conversation
ComposerImpl.changed() boxes Float? and calls Float.equals() at the ART native level, triggering a known crash. Non-null Float params use the primitive overload with no boxing. Introduces BATTERY_UNKNOWN sentinel, toBatteryFloat(), and toBatteryOrNull() extensions to eliminate Float? from all composable signatures and WidgetRenderState data classes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Fixed a native crash that could happen when the app displays or updates battery levels for AirPods. The crash occurred during screen refreshes and could affect the main dashboard, case-open popup, and home screen widgets.
Technical Context
ComposerImpl.changed()boxesFloat?parameters and callsFloat.equals()at the ART native level, triggering a known JIT/AOT compilation crash. Non-nullFloatparameters use a primitive overload that avoids boxing entirely.Float?) now use non-nullFloatwith a sentinel value (BATTERY_UNKNOWN = -1f). Two small extension functions (toBatteryFloat()/toBatteryOrNull()) centralize the conversion at the boundary between domain models (which correctly usenullfor unknown) and UI composables.WidgetRenderStatedata classes which are passed as composable parameters — their auto-generatedequals()would internally callFloat.equals()on nullable fields, hitting the same crash path.