refactor: unify/cleanup methods of treecrdt in core package#124
Merged
Antonov548 merged 5 commits intomainfrom Apr 21, 2026
Merged
refactor: unify/cleanup methods of treecrdt in core package#124Antonov548 merged 5 commits intomainfrom
Antonov548 merged 5 commits intomainfrom
Conversation
89a5945 to
0fc9cec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor: unify
apply_remoteand simplifyTreeCrdtAPIReduces API surface of
treecrdt-coreby merging three remote-apply methods into one unifiedapply_remote, removing dead code, and extracting helpers into dedicated modules.Key changes
apply_remote: mergedapply_remote(),apply_remote_with_delta(), andapply_remote_with_materialization_seq()into a singleapply_remote() -> Result<Option<ApplyDelta>>. Materialization behavior is driven by a newParentOpIndextype parameter onTreeCrdt(defaults toNoopParentOpIndex— compiles to no-ops for in-memory/WASM usage).finalize_local: removed external&mut indexparameter; uses the embedded index.local_insert,local_move,local_delete,local_payload.types.rs, affected-node helpers toaffected.rs, validation tovalidation.rs—tree.rsreduced from 1200 to 780 lines.PersistedRemoteStoreswithMaterializationStoresstruct used by bothmaterialize_persisted_remote_ops_with_deltaandcatch_up_materialized_state.Adapter impact
appendOp/appendOpWithDeltacall unifiedapply_remote.TreeCrdtnow constructed with the realParentOpIndeximpl;finalize_localcalls simplified.