Fix hassfest: use description placeholders instead of inline URLs in translations#201
Open
Fix hassfest: use description placeholders instead of inline URLs in translations#201
Conversation
Co-authored-by: ludeeus <15093472+ludeeus@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix invalid translations in en.json for hassfest
Fix hassfest: use description placeholders instead of inline URLs in translations
Mar 17, 2026
ludeeus
reviewed
Mar 17, 2026
Co-authored-by: ludeeus <15093472+ludeeus@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the Healthchecks.io config flow translations to satisfy hassfest’s rule forbidding raw URLs in translation strings by moving the URL into description_placeholders provided at runtime.
Changes:
- Replaced inline GitHub URLs in
translations/en.jsonstep descriptions with a{docs_url}placeholder. - Added
description_placeholdersto bothasync_show_formcalls inconfig_flow.pyto supply the docs URL at runtime.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| custom_components/healthchecksio/translations/en.json | Replaces raw URLs with a {docs_url} placeholder in config flow step descriptions. |
| custom_components/healthchecksio/config_flow.py | Supplies description_placeholders so {docs_url} is resolved when forms are shown. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hassfest rejects translation strings that contain raw URLs; they must be provided via
description_placeholdersinstead.Changes
translations/en.json: Replace hardcoded URLs instep.user.descriptionandstep.self_hosted.descriptionwith a{docs_url}placeholder that inlines the URL directly:config_flow.py: Passdescription_placeholdersto bothasync_show_formcalls to resolve the placeholder at runtime:🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.