Skip to content

Fix hassfest: use description placeholders instead of inline URLs in translations#201

Open
Copilot wants to merge 5 commits intomainfrom
copilot/fix-invalid-translations-json
Open

Fix hassfest: use description placeholders instead of inline URLs in translations#201
Copilot wants to merge 5 commits intomainfrom
copilot/fix-invalid-translations-json

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 17, 2026

hassfest rejects translation strings that contain raw URLs; they must be provided via description_placeholders instead.

Changes

  • translations/en.json: Replace hardcoded URLs in step.user.description and step.self_hosted.description with a {docs_url} placeholder that inlines the URL directly:
    "description": "If you need help with the configuration, have a look here: {docs_url}"
  • config_flow.py: Pass description_placeholders to both async_show_form calls to resolve the placeholder at runtime:
    description_placeholders={"docs_url": "https://github.com/custom-components/healthchecksio"}

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Co-authored-by: ludeeus <15093472+ludeeus@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix invalid translations in en.json for hassfest Fix hassfest: use description placeholders instead of inline URLs in translations Mar 17, 2026
Copilot AI requested a review from ludeeus March 17, 2026 07:34
Comment thread custom_components/healthchecksio/translations/en.json Outdated
Co-authored-by: ludeeus <15093472+ludeeus@users.noreply.github.com>
Copilot AI requested a review from ludeeus March 17, 2026 07:40
@ludeeus ludeeus marked this pull request as ready for review March 17, 2026 07:44
Copilot AI review requested due to automatic review settings March 17, 2026 07:44
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Healthchecks.io config flow translations to satisfy hassfest’s rule forbidding raw URLs in translation strings by moving the URL into description_placeholders provided at runtime.

Changes:

  • Replaced inline GitHub URLs in translations/en.json step descriptions with a {docs_url} placeholder.
  • Added description_placeholders to both async_show_form calls in config_flow.py to supply the docs URL at runtime.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
custom_components/healthchecksio/translations/en.json Replaces raw URLs with a {docs_url} placeholder in config flow step descriptions.
custom_components/healthchecksio/config_flow.py Supplies description_placeholders so {docs_url} is resolved when forms are shown.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread custom_components/healthchecksio/config_flow.py
Comment thread custom_components/healthchecksio/config_flow.py Outdated
ludeeus and others added 2 commits March 17, 2026 08:48
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@ludeeus ludeeus added the bugfix label Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants