QB-489: Add Jenkinsfile#151
Open
juan-comesana-curity wants to merge 3 commits intodevfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a Jenkins pipeline entrypoint intended to run tests on branches and PRs, but it also bundles a broad set of UI, template, localization, build-tooling, and dependency updates across the monorepo.
Changes:
- Add a Jenkinsfile that delegates PR test execution to a shared Jenkins library.
- Update UI behavior and i18n strings in the Self Service Portal (account delete texts, phone-number error messaging, and “disallow delete last authenticator/passkey” messaging).
- Refactor Identity Server BankID templates/fragments and upgrade tooling/dependencies (Node/npm engine bumps, Dialog migration to Radix, CSS and build configuration updates).
Reviewed changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/self-service-portal/messages/sv/apps/self-service-portal/security.properties | Adds Swedish “disallow deletion” descriptions for passkeys and OTP authenticators. |
| src/self-service-portal/messages/sv/apps/self-service-portal/error.properties | Adds Swedish error message for duplicate primary phone number. |
| src/self-service-portal/messages/sv/apps/self-service-portal/account.properties | Adds Swedish “account delete” UI strings. |
| src/self-service-portal/messages/pt/apps/self-service-portal/security.properties | Adds Portuguese “disallow deletion” descriptions for passkeys and OTP authenticators. |
| src/self-service-portal/messages/pt/apps/self-service-portal/error.properties | Adds Portuguese error message for duplicate primary phone number. |
| src/self-service-portal/messages/pt/apps/self-service-portal/account.properties | Adds Portuguese “account delete” UI strings. |
| src/self-service-portal/messages/pt-pt/apps/self-service-portal/security.properties | Adds pt-PT “disallow deletion” descriptions for passkeys and OTP authenticators. |
| src/self-service-portal/messages/pt-pt/apps/self-service-portal/error.properties | Adds pt-PT error message for duplicate primary phone number. |
| src/self-service-portal/messages/pt-pt/apps/self-service-portal/account.properties | Adds pt-PT “account delete” UI strings. |
| src/self-service-portal/messages/en/apps/self-service-portal/security.properties | Adds English “disallow deletion” descriptions for passkeys and OTP authenticators. |
| src/self-service-portal/messages/en/apps/self-service-portal/error.properties | Adds English error message for duplicate primary phone number. |
| src/self-service-portal/messages/en/apps/self-service-portal/account.properties | Adds English “account delete” UI strings. |
| src/self-service-portal/app/src/shared/data-access/API/user-management/USER_MANAGEMENT_ERROR_MESSAGES.ts | Extends error-message key mapping to support a duplicate-phone-number case. |
| src/self-service-portal/app/src/pages/security/phone/PhoneNumberVerificationDialog.tsx | Improves mutation error handling and shows a specific message for duplicate phone numbers. |
| src/self-service-portal/app/src/pages/security/Totp.tsx | Disables OTP device deletion when the last device is in use; adds UI hint text. |
| src/self-service-portal/app/src/pages/security/Passkeys/Passkeys.tsx | Disables passkey deletion for the last passkey in use; adds UI hint text. |
| src/self-service-portal/app/package.json | Updates Node/npm engine constraints and bumps/realigns dependencies. |
| src/self-service-portal/app/.nvmrc | Removes package-level Node version pin. |
| src/self-service-portal/app/.npmrc | Removes legacy-peer-deps setting. |
| src/self-service-portal/README.md | Updates documentation link for localization resources. |
| src/identity-server/vite.config.ts | Adds a watch plugin to rebuild styles when shared CSS library sources change. |
| src/identity-server/templates/core/settings.vm | Adds a toggle for BankID consentor “launch template v2”. |
| src/identity-server/templates/core/settings-defaults.vm | Adds default value for BankID consentor “launch template v2”. |
| src/identity-server/templates/core/fragments/bankid/check-platform-capabilities.js.vm | Updates template parse paths to new shared BankID fragments location. |
| src/identity-server/templates/core/fragments/bankid/browsers/safari-iphone.js.vm | Adds iPhone Safari browser strategy for BankID launching. |
| src/identity-server/templates/core/fragments/bankid/browsers/safari-ipad.js.vm | Adds iPad Safari browser strategy for BankID launching. |
| src/identity-server/templates/core/fragments/bankid/browsers/firefox-ios.js.vm | Adds iOS Firefox browser strategy for BankID launching. |
| src/identity-server/templates/core/fragments/bankid/browsers/edge-ios.js.vm | Adds iOS Edge browser strategy for BankID launching. |
| src/identity-server/templates/core/fragments/bankid/browsers/default-android.js.vm | Adds Android default browser strategy for BankID launching. |
| src/identity-server/templates/core/fragments/bankid/browsers/chrome-ios.js.vm | Adds iOS Chrome browser strategy for BankID launching. |
| src/identity-server/templates/core/fragments/bankid/browsers/browser-strategy.js.vm | Introduces shared browser-strategy implementation for BankID app launch behaviors. |
| src/identity-server/templates/core/fragments/bankid/browsers/available-browser-detections.vm | Updates parse includes for available browser detections to new fragment paths. |
| src/identity-server/templates/core/fragments/bankid/bankid-poller.vm | Refactors BankID poller into a shared fragment using injected settings and callbacks. |
| src/identity-server/templates/core/fragments/bankid/bankid-app-launcher.vm | Refactors BankID launcher to use shared poller + injected settings object. |
| src/identity-server/templates/core/consentor/bankid-signing-consentor/bankid-polling-settings.vm | Adds consentor-specific JS settings for shared BankID poller/launcher fragments. |
| src/identity-server/templates/core/consentor/bankid-signing-consentor/bankid-poller.vm | Adds feature-flagged path to use new shared BankID poller/launcher in consentor flow. |
| src/identity-server/templates/core/authenticator/bankid/launch/index.vm | Updates authenticator launch page behavior (flow-mode links, new shared poller integration). |
| src/identity-server/templates/core/authenticator/bankid/launch/bankid-polling-settings.vm | Adds authenticator-specific JS settings for shared BankID poller/launcher fragments. |
| src/identity-server/templates/core/authenticator/bankid/enter-personalnumber/compute-browser-context.vm | Adds redirect-based browser context collection (e.g., maxTouchPoints). |
| src/identity-server/scripts/curity-ui.js | Refactors parts of the UI helper script (const/let usage, helper extraction). |
| src/identity-server/previewer.js | Improves Node script robustness (Error throws, semicolons, LISTING_TEMPLATE support). |
| src/identity-server/package.json | Updates Node/npm engine constraints. |
| src/identity-server/messages/core/sv/authenticator/bankid/launch.properties | Adds new Swedish BankID launch button labels. |
| src/identity-server/messages/core/pt/authenticator/bankid/launch.properties | Adds new Portuguese BankID launch button labels. |
| src/identity-server/messages/core/pt-pt/authenticator/bankid/launch.properties | Adds new pt-PT BankID launch button labels. |
| src/identity-server/messages/core/en/authenticator/bankid/launch.properties | Adds new English BankID launch button labels. |
| src/identity-server/README.md | Updates prerequisites to Node 22.22.0 / npm 10.9.4. |
| src/common/icons/rollup.config.js | Switches terser plugin import to @rollup/plugin-terser. |
| src/common/icons/package.json | Replaces rollup-plugin-terser with @rollup/plugin-terser. |
| src/common/css/lib/src/base/base-buttons.css | Adjusts submit/button sizing rules and selector logic. |
| src/common/css/lib/src/base/base-authenticator-buttons.css | Refactors authenticator button coloring to use a CSS variable approach. |
| src/common/css/lib/readme.md | Clarifies setup instructions (run from monorepo root). |
| src/common/css/lib/package.json | Updates Vite version. |
| src/common/css/lib/package-lock.json | Removes per-package lockfile (root lockfile remains). |
| src/common/css/lib/.npmrc | Removes legacy-peer-deps. |
| src/common/css/docs/package.json | Upgrades Astro/React-related dependencies and Rollup. |
| src/common/css/docs/README.md | Clarifies setup instructions (run from monorepo root). |
| src/common/css/docs/.npmrc | Removes legacy-peer-deps. |
| src/common/component-library/src/components/dialog/Dialog.tsx | Migrates Dialog implementation from @reach/dialog to @radix-ui/react-dialog. |
| src/common/component-library/src/components/dialog/Dialog.module.css | Updates overlay styling to match Radix overlay element. |
| src/common/component-library/src/components/ConfirmButton.tsx | Updates close callback type to accept optional event (Dialog API change). |
| src/common/component-library/package.json | Updates engines, peer deps, and replaces @reach/dialog with @radix-ui/react-dialog. |
| src/common/component-library/README.md | Updates prerequisites and dependency documentation for Radix dialog. |
| src/common/component-library/.nvmrc | Removes package-level Node version pin. |
| src/common/component-library/.npmrc | Removes legacy-peer-deps setting. |
| src/common/assets/images/ui-kit-start.jpg | Repository image asset referenced by docs/site. |
| src/common/assets/images/ui-kit-start-dark.svg | Adds a dark-mode SVG image for docs/README rendering. |
| package.json | Adds root engines and changes component-library start script to watch mode. |
| index.html | Updates landing page styling/links and switches welcome image to SVG. |
| README.md | Updates badges and switches hero image to a light/dark |
| Jenkinsfile | Adds Jenkins pipeline entrypoint using shared library step. |
| .nvmrc | Updates root Node version pin to 22.22.0. |
| .npmrc | Removes legacy-peer-deps setting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+3
| @Library('jenkins-shared-library') _ | ||
| executeUiKitPrTests { | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It will run the tests for branches and PRs