Skip to content

Fix useless cast from decimal #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mborland merged 3 commits into from
Mar 31, 2026
Merged

Fix useless cast from decimal #380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
491bd26
Remove useless cast
mborland Mar 31, 2026
d725c68
Ignore useless cast warning since it's only useless on 32-bit
mborland Mar 31, 2026
f3884ce
Clang does not have -Wuseless-cast
mborland Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/boost/int128/detail/int128_imp.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3264,7 +3264,7 @@ BOOST_INT128_HOST_DEVICE constexpr int128_t operator%(const int128_t lhs, const
}
#else

const auto is_neg{static_cast<bool>(lhs < 0)};
const auto is_neg{lhs < 0};

int128_t remainder {};

Expand Down
13 changes: 12 additions & 1 deletion include/boost/int128/detail/mini_from_chars.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ BOOST_INT128_HOST_DEVICE constexpr int from_chars_integer_impl(const char* first
}

// Return the parsed value, adding the sign back if applicable
// If we have overflowed then we do not return the result
// If we have overflowed, then we do not return the result
if (overflowed)
{
return EDOM;
Expand All @@ -201,7 +201,18 @@ BOOST_INT128_HOST_DEVICE constexpr int from_chars_integer_impl(const char* first

// This value will be negative to differentiate from errno values
// since they are in the range of acceptable distances

// This cast is useless on 32-bit platforms
#if defined(__GNUC__) && !defined(__clang__)
# pragma GCC diagnostic push
# pragma GCC diagnostic ignored "-Wuseless-cast"
#endif

return static_cast<int>(first - next);

#if defined(__GNUC__) && !defined(__clang__)
# pragma GCC diagnostic pop
#endif
}
} // namespace impl

Expand Down
Loading